Skip to content

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Jun 3, 2025


PR-Codex overview

This PR adds a new entry for the Plume mainnet in the fee-data.ts file, indicating support for this network.

Detailed summary

  • Added a new entry +98866 for Plume mainnet in the array of fee data.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Chores
    • Updated support for gas pricing on the Plume mainnet chain.

@0xFirekeeper 0xFirekeeper requested review from a team as code owners June 3, 2025 18:24
Copy link

changeset-bot bot commented Jun 3, 2025

⚠️ No Changeset found

Latest commit: 21a3947

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2025 6:33pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2025 6:33pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2025 6:33pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2025 6:33pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2025 6:33pm

Copy link
Contributor

graphite-app bot commented Jun 3, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

coderabbitai bot commented Jun 3, 2025

Walkthrough

The update adds the chain ID 98866 (Plume mainnet) to the FORCE_GAS_PRICE_CHAIN_IDS array in the gas fee data module, ensuring that legacy gas pricing is enforced for this chain. No other code or exported entities are changed.

Changes

File(s) Change Summary
packages/thirdweb/src/gas/fee-data.ts Added chain ID 98866 to FORCE_GAS_PRICE_CHAIN_IDS.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dfe4cf0 and 21a3947.

📒 Files selected for processing (1)
  • packages/thirdweb/src/gas/fee-data.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Unit Tests
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Size
  • GitHub Check: Lint Packages
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
packages/thirdweb/src/gas/fee-data.ts (1)

49-49: Correctly enforce legacy gas pricing for Plume mainnet
The chain ID 98866 has been added to FORCE_GAS_PRICE_CHAIN_IDS, ensuring legacy gas pricing is applied for Plume.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jun 3, 2025
@0xFirekeeper 0xFirekeeper added merge-queue Adds the pull request to Graphite's merge queue. hotfix This pull request should be prioritized in the merge queue. and removed packages SDK Involves changes to the thirdweb SDK labels Jun 3, 2025
Copy link
Member Author

0xFirekeeper commented Jun 3, 2025

Merge activity

  • Jun 3, 6:25 PM UTC: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 3, 7:17 PM UTC: The merge label 'hotfix' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

Copy link
Contributor

github-actions bot commented Jun 3, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.57 KB (+0.01% 🔺) 1.3 s (+0.01% 🔺) 333 ms (+19.87% 🔺) 1.6 s
thirdweb (cjs) 345.38 KB (-0.07% 🔽) 7 s (-0.07% 🔽) 2.1 s (-1.76% 🔽) 9 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 78 ms (+357.82% 🔺) 192 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 9 ms (+37.15% 🔺) 20 ms
thirdweb/react (minimal + tree-shaking) 19.56 KB (0%) 392 ms (0%) 111 ms (+113.78% 🔺) 502 ms

@jnsdls jnsdls merged commit 5ebb754 into main Jun 3, 2025
21 of 22 checks passed
@jnsdls jnsdls deleted the firekeeper/plume-legacy branch June 3, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix This pull request should be prioritized in the merge queue. merge-queue Adds the pull request to Graphite's merge queue. SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants