-
Notifications
You must be signed in to change notification settings - Fork 584
Dashboard: NFT asset page UI updates #7388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
""" WalkthroughThe updates modify UI components related to NFT display and purchasing. They introduce a tabbed interface for ERC1155 tokens in the token viewer, enhance claim condition handling, reorganize trait and purchase sections, and adjust form spacing and styling. A new message is shown when NFTs are not available for purchase. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant TokenInfoUI
participant BuyEditionDrop
participant TraitsGrid
User->>TokenInfoUI: View NFT details
TokenInfoUI->>TokenInfoUI: Check token type (ERC1155/721)
alt ERC1155
TokenInfoUI->>User: Show tabs (Traits / Buy NFT)
User->>TokenInfoUI: Select tab
alt Traits tab
TokenInfoUI->>TraitsGrid: Render traits
else Buy NFT tab
TokenInfoUI->>TokenInfoUI: Check claim condition
alt Claimable
TokenInfoUI->>BuyEditionDrop: Render buy interface
else Not claimable
TokenInfoUI->>User: Show "Not available for purchase"
end
end
else ERC721
TokenInfoUI->>TraitsGrid: Render traits (no tabs)
TokenInfoUI->>User: Show purchase availability message
end
Suggested reviewers
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (5)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
8943361
to
4c29886
Compare
e77aa46
to
a769a04
Compare
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7388 +/- ##
=======================================
Coverage 52.44% 52.44%
=======================================
Files 941 941
Lines 63199 63199
Branches 4226 4226
=======================================
Hits 33142 33142
Misses 29950 29950
Partials 107 107
🚀 New features to boost your workflow:
|
a769a04
to
8b8efbc
Compare
size-limit report 📦
|
Merge activity
|
<!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR enhances the `TokenInfoUI` component by adding a new claim condition check, improving the UI for displaying NFT purchase availability, and restructuring the layout for better clarity. It also introduces a tabbed interface for viewing traits and purchasing options for ERC1155 tokens. ### Detailed summary - Added a new check for claim conditions in `TokenInfoUI`. - Introduced a "Not available for purchase" message when no claim conditions are set. - Implemented a tabbed interface for ERC1155 tokens to switch between traits and purchase options. - Reorganized the layout of the NFT details section for improved readability. - Adjusted spacing in the `BuyEditionDrop` form for consistency. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a tabbed interface for ERC1155 tokens, allowing users to switch between viewing traits and purchasing options. - Added badges displaying token type, token ID, and chain metadata for improved clarity. - **Improvements** - Enhanced handling of claim conditions, now clearly indicating when an NFT is not available for purchase. - Refined the display of NFT traits, showing a "No Traits" message if none exist. - Updated form and input styling for a cleaner and more consistent appearance. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
8b8efbc
to
492c6d0
Compare
PR-Codex overview
This PR enhances the NFT overview functionality by adding checks for claim conditions, improving UI elements, and restructuring the layout for better user experience. It introduces new components and modifies existing ones to handle different states of NFT availability.
Detailed summary
noClaimConditionSet
to display "Not available for purchase".BuyEditionDrop
form to reduce spacing fromspace-y-5
tospace-y-4
.DynamicHeight
intoken-viewer.tsx
for better layout control.TabButtons
for toggling between "Traits" and "Buy NFT".Summary by CodeRabbit
New Features
Improvements