Skip to content

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Jun 19, 2025


PR-Codex overview

This PR enhances the NFT overview functionality by adding checks for claim conditions, improving UI elements, and restructuring the layout for better user experience. It introduces new components and modifies existing ones to handle different states of NFT availability.

Detailed summary

  • Added a check for noClaimConditionSet to display "Not available for purchase".
  • Updated the BuyEditionDrop form to reduce spacing from space-y-5 to space-y-4.
  • Introduced DynamicHeight in token-viewer.tsx for better layout control.
  • Added TabButtons for toggling between "Traits" and "Buy NFT".
  • Enhanced the UI to show NFT availability based on claim conditions.
  • Created a new attributes UI section to display traits or a message if none are available.
  • Refactored badge display for better clarity and organization.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features

    • Introduced a tabbed interface for ERC1155 tokens, allowing users to switch between viewing traits and purchasing options.
    • Added badges displaying token type, token ID, and chain metadata for improved clarity.
  • Improvements

    • Enhanced handling of claim conditions, now clearly indicating when an NFT is not available for purchase.
    • Refined the display of NFT traits, showing a "No Traits" message if none exist.
    • Updated form and input styling for a cleaner and more consistent appearance.

Copy link

changeset-bot bot commented Jun 19, 2025

⚠️ No Changeset found

Latest commit: 492c6d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 19, 2025 16:24 Inactive
Copy link

vercel bot commented Jun 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2025 6:22pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jun 19, 2025 6:22pm
login ⬜️ Skipped (Inspect) Jun 19, 2025 6:22pm
nebula ⬜️ Skipped (Inspect) Jun 19, 2025 6:22pm
thirdweb_playground ⬜️ Skipped (Inspect) Jun 19, 2025 6:22pm
wallet-ui ⬜️ Skipped (Inspect) Jun 19, 2025 6:22pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 June 19, 2025 16:24 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 19, 2025 16:24 Inactive
Copy link
Contributor

coderabbitai bot commented Jun 19, 2025

"""

Walkthrough

The updates modify UI components related to NFT display and purchasing. They introduce a tabbed interface for ERC1155 tokens in the token viewer, enhance claim condition handling, reorganize trait and purchase sections, and adjust form spacing and styling. A new message is shown when NFTs are not available for purchase.

Changes

Files/Paths Change Summary
.../buy-edition-drop/buy-edition-drop.client.tsx Reduced form element spacing and simplified input styling; no logic changes.
.../public-pages/nft/overview/nfts-grid.tsx Added early return with "Not available for purchase" message if no claim condition is set.
.../public-pages/nft/token-viewer/token-viewer.tsx Added tabbed UI for ERC1155 tokens, improved claimability logic, reorganized traits and badges.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant TokenInfoUI
    participant BuyEditionDrop
    participant TraitsGrid

    User->>TokenInfoUI: View NFT details
    TokenInfoUI->>TokenInfoUI: Check token type (ERC1155/721)
    alt ERC1155
        TokenInfoUI->>User: Show tabs (Traits / Buy NFT)
        User->>TokenInfoUI: Select tab
        alt Traits tab
            TokenInfoUI->>TraitsGrid: Render traits
        else Buy NFT tab
            TokenInfoUI->>TokenInfoUI: Check claim condition
            alt Claimable
                TokenInfoUI->>BuyEditionDrop: Render buy interface
            else Not claimable
                TokenInfoUI->>User: Show "Not available for purchase"
            end
        end
    else ERC721
        TokenInfoUI->>TraitsGrid: Render traits (no tabs)
        TokenInfoUI->>User: Show purchase availability message
    end
Loading

Suggested reviewers

  • jnsdls
    """

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8b8efbc and 492c6d0.

📒 Files selected for processing (3)
  • apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/nft/overview/buy-edition-drop/buy-edition-drop.client.tsx (2 hunks)
  • apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/nft/overview/nfts-grid.tsx (1 hunks)
  • apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/nft/token-viewer/token-viewer.tsx (4 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/nft/overview/buy-edition-drop/buy-edition-drop.client.tsx
  • apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/nft/overview/nfts-grid.tsx
  • apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/nft/token-viewer/token-viewer.tsx
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Size
  • GitHub Check: Unit Tests
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel vercel bot temporarily deployed to Preview – nebula June 19, 2025 16:24 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 19, 2025 16:24 Inactive
@MananTank MananTank marked this pull request as ready for review June 19, 2025 16:24
@MananTank MananTank requested review from a team as code owners June 19, 2025 16:24
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jun 19, 2025
@MananTank MananTank changed the base branch from 06-19-_tool-4831_sdk_fix_mediarenderer_not_showing_poster_for_3d_models to graphite-base/7388 June 19, 2025 16:25
@MananTank MananTank force-pushed the graphite-base/7388 branch from 8943361 to 4c29886 Compare June 19, 2025 16:25
@MananTank MananTank force-pushed the 06-19-dashboard_nft_asset_page_ui_updates branch from e77aa46 to a769a04 Compare June 19, 2025 16:25
@vercel vercel bot temporarily deployed to Preview – login June 19, 2025 16:25 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 19, 2025 16:25 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 19, 2025 16:25 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 19, 2025 16:25 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula June 19, 2025 16:25 Inactive
@MananTank MananTank changed the base branch from graphite-base/7388 to main June 19, 2025 16:25
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.44%. Comparing base (787118d) to head (492c6d0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7388   +/-   ##
=======================================
  Coverage   52.44%   52.44%           
=======================================
  Files         941      941           
  Lines       63199    63199           
  Branches     4226     4226           
=======================================
  Hits        33142    33142           
  Misses      29950    29950           
  Partials      107      107           
Flag Coverage Δ
packages 52.44% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MananTank MananTank force-pushed the 06-19-dashboard_nft_asset_page_ui_updates branch from a769a04 to 8b8efbc Compare June 19, 2025 18:00
@vercel vercel bot temporarily deployed to Preview – nebula June 19, 2025 18:00 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 19, 2025 18:00 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 19, 2025 18:00 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 19, 2025 18:00 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 19, 2025 18:00 Inactive
Copy link
Contributor

github-actions bot commented Jun 19, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.53 KB (0%) 1.3 s (0%) 247 ms (+106.8% 🔺) 1.5 s
thirdweb (cjs) 350.55 KB (0%) 7.1 s (0%) 959 ms (+2.74% 🔺) 8 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 107 ms (+1392.7% 🔺) 221 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 68 ms (+2322.86% 🔺) 79 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 116 ms (+591.96% 🔺) 508 ms

Copy link
Contributor

graphite-app bot commented Jun 19, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR enhances the `TokenInfoUI` component by adding a new claim condition check, improving the UI for displaying NFT purchase availability, and restructuring the layout for better clarity. It also introduces a tabbed interface for viewing traits and purchasing options for ERC1155 tokens.

### Detailed summary
- Added a new check for claim conditions in `TokenInfoUI`.
- Introduced a "Not available for purchase" message when no claim conditions are set.
- Implemented a tabbed interface for ERC1155 tokens to switch between traits and purchase options.
- Reorganized the layout of the NFT details section for improved readability.
- Adjusted spacing in the `BuyEditionDrop` form for consistency.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit

- **New Features**
	- Introduced a tabbed interface for ERC1155 tokens, allowing users to switch between viewing traits and purchasing options.
	- Added badges displaying token type, token ID, and chain metadata for improved clarity.

- **Improvements**
	- Enhanced handling of claim conditions, now clearly indicating when an NFT is not available for purchase.
	- Refined the display of NFT traits, showing a "No Traits" message if none exist.
	- Updated form and input styling for a cleaner and more consistent appearance.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the 06-19-dashboard_nft_asset_page_ui_updates branch from 8b8efbc to 492c6d0 Compare June 19, 2025 18:13
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 19, 2025 18:13 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 19, 2025 18:13 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 19, 2025 18:13 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 19, 2025 18:13 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula June 19, 2025 18:13 Inactive
@graphite-app graphite-app bot merged commit 492c6d0 into main Jun 19, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 06-19-dashboard_nft_asset_page_ui_updates branch June 19, 2025 18:22
@vercel vercel bot temporarily deployed to Production – wallet-ui June 19, 2025 18:22 Inactive
@vercel vercel bot temporarily deployed to Production – nebula June 19, 2025 18:22 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground June 19, 2025 18:22 Inactive
@vercel vercel bot temporarily deployed to Production – login June 19, 2025 18:22 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 June 19, 2025 18:22 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants