add eoa execution options type #7428

d4mr · 2025-06-24T02:34:11Z

PR-Codex overview

This PR introduces support for EoaExecutionOptions in the ServerWalletOptions and various transaction-related types, allowing for execution using externally owned accounts (EOA). This enhances the flexibility of transaction handling in the wallet.

Detailed summary

Added EoaExecutionOptions type with properties: type, address, chainId, and optional idempotencyKey.
Updated ServerWalletOptions to include EoaExecutionOptions.
Modified executionOptions in WriteContractData, SendTransactionData, SignTransactionData, SignMessageData, and SignTypedDataData to include EoaExecutionOptions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

New Features
- Added support for execution options using externally owned accounts (EOA) for signing transactions, messages, and typed data.
- Expanded wallet configuration options to include EOA-based execution alongside existing account abstraction options.

changeset-bot · 2025-06-24T02:34:14Z

⚠️ No Changeset found

Latest commit: a2f1911

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-06-24T02:34:15Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 24, 2025 2:49am
nebula	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 24, 2025 2:49am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 24, 2025 2:49am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 24, 2025 2:49am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 24, 2025 2:49am

graphite-app · 2025-06-24T02:34:18Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

coderabbitai · 2025-06-24T02:34:18Z

Walkthrough

A new EoaExecutionOptions type was introduced to support execution using Externally Owned Accounts (EOA), currently for signing operations. This type was added to relevant union types in both client and server wallet option definitions, expanding the supported execution options for signing transactions, messages, and typed data.

Changes

File(s)	Change Summary
packages/engine/src/client/types.gen.ts	Added `EoaExecutionOptions` type; extended `executionOptions` union in signing-related data types.
packages/thirdweb/src/engine/server-wallet.ts	Updated `ServerWalletOptions.executionOptions` to include `EoaExecutionOptions` (with `chainId` omitted).

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant ServerWallet

    Client->>ServerWallet: Send sign request (SignTransaction/SignMessage/SignTypedData) with executionOptions (can be EOA)
    ServerWallet-->>Client: Process request using EoaExecutionOptions if provided

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bce8ae2 and a2f1911.

📒 Files selected for processing (1)

packages/engine/src/client/types.gen.ts (6 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/engine/src/client/types.gen.ts

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: Size
GitHub Check: E2E Tests (pnpm, esbuild)
GitHub Check: Lint Packages
GitHub Check: Build Packages
GitHub Check: Analyze (javascript)

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

joaquim-verges · 2025-06-24T02:45:37Z

Merge activity

Jun 24, 2:45 AM UTC: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jun 24, 2:51 AM UTC: joaquim-verges added this pull request to the Graphite merge queue.

github-actions · 2025-06-24T02:46:10Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	62.56 KB (0%)	1.3 s (0%)	447 ms (+61.82% 🔺)	1.7 s
thirdweb (cjs)	350.74 KB (0%)	7.1 s (0%)	2.2 s (+1.46% 🔺)	9.3 s
thirdweb (minimal + tree-shaking)	5.72 KB (0%)	115 ms (0%)	263 ms (+1558.79% 🔺)	377 ms
thirdweb/chains (tree-shaking)	530 B (0%)	11 ms (0%)	38 ms (+500.38% 🔺)	49 ms
thirdweb/react (minimal + tree-shaking)	19.61 KB (0%)	393 ms (0%)	118 ms (+204.53% 🔺)	511 ms

codecov · 2025-06-24T02:47:13Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.08%. Comparing base (c26be2d) to head (a2f1911).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7428   +/-   ##
=======================================
  Coverage   52.08%   52.08%           
=======================================
  Files         947      947           
  Lines       63636    63636           
  Branches     4216     4214    -2     
=======================================
  Hits        33146    33146           
  Misses      30384    30384           
  Partials      106      106

Flag	Coverage Δ
packages	`52.08% <ø> (ø)`

Files with missing lines	Coverage Δ
packages/thirdweb/src/engine/server-wallet.ts	`4.62% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

add eoa execution options type

bce8ae2

d4mr requested review from a team as code owners June 24, 2025 02:34

github-actions bot assigned d4mr Jun 24, 2025

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jun 24, 2025

vercel bot had a problem deploying to Preview – thirdweb_playground June 24, 2025 02:34 Failure

vercel bot had a problem deploying to Preview – thirdweb-www June 24, 2025 02:34 Failure

vercel bot had a problem deploying to Preview – nebula June 24, 2025 02:34 Failure

vercel bot had a problem deploying to Preview – docs-v2 June 24, 2025 02:35 Failure

joaquim-verges approved these changes Jun 24, 2025

View reviewed changes

vercel bot had a problem deploying to Preview – wallet-ui June 24, 2025 02:35 Failure

fix build errors

a2f1911

vercel bot deployed to Preview – nebula June 24, 2025 02:42 View deployment

vercel bot deployed to Preview – wallet-ui June 24, 2025 02:43 View deployment

vercel bot deployed to Preview – thirdweb_playground June 24, 2025 02:44 View deployment

joaquim-verges added the merge-queue Adds the pull request to Graphite's merge queue. label Jun 24, 2025

vercel bot deployed to Preview – thirdweb-www June 24, 2025 02:48 View deployment

vercel bot deployed to Preview – docs-v2 June 24, 2025 02:49 View deployment

joaquim-verges merged commit cf44dae into main Jun 24, 2025
24 checks passed

joaquim-verges deleted the pb/eoa-signatures-engine branch June 24, 2025 02:51

graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Jun 24, 2025

coderabbitai bot mentioned this pull request Jun 24, 2025

Implement support for EOA execution options in server wallets #7429

Merged

coderabbitai bot mentioned this pull request Jun 25, 2025

Update engine API #7427

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add eoa execution options type #7428

add eoa execution options type #7428

Uh oh!

d4mr commented Jun 24, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Jun 24, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jun 24, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Jun 24, 2025

Uh oh!

coderabbitai bot commented Jun 24, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

joaquim-verges commented Jun 24, 2025 •

edited by graphite-app bot

Loading

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

codecov bot commented Jun 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

add eoa execution options type #7428

add eoa execution options type #7428

Uh oh!

Conversation

d4mr commented Jun 24, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Jun 24, 2025

How to use the Graphite Merge Queue

Uh oh!

coderabbitai bot commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

joaquim-verges commented Jun 24, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

github-actions bot commented Jun 24, 2025

size-limit report 📦

Uh oh!

codecov bot commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

d4mr commented Jun 24, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Jun 24, 2025 •

edited

Loading

vercel bot commented Jun 24, 2025 •

edited

Loading

coderabbitai bot commented Jun 24, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

joaquim-verges commented Jun 24, 2025 •

edited by graphite-app bot

Loading

codecov bot commented Jun 24, 2025 •

edited

Loading