-
Notifications
You must be signed in to change notification settings - Fork 567
[TOOL-4959] Dashboard: Asset page UI improvements #7599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TOOL-4959] Dashboard: Asset page UI improvements #7599
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
""" WalkthroughThis update restructures the ERC20 token asset page, introducing token price data fetching and conditional display of the price chart. The metadata header is visually enhanced and repositioned, the buy card is placed beside the header, and the layout is adjusted for improved hierarchy and responsiveness. Supporting components and styling are updated accordingly. Changes
Sequence Diagram(s)sequenceDiagram
participant Page as ERC20PublicPage
participant API as Token Price API
participant TokenStats as TokenStats
participant Chart as ContractAnalyticsOverview
participant Recent as RecentTransfers
Page->>API: getTokenPriceData(chainId, contractAddress)
API-->>Page: tokenPriceData (or undefined)
Page->>Page: Render PageHeader, ContractHeaderUI, BuyCard, GridPattern
alt tokenPriceData available
Page->>TokenStats: Render with tokenPriceData
Page->>Chart: Render analytics overview
else tokenPriceData not available
Page->>Chart: Render analytics overview only
end
Page->>Recent: Render recent transfers
Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (15)
💤 Files with no reviewable changes (2)
🚧 Files skipped from review as they are similar to previous changes (13)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7599 +/- ##
=======================================
Coverage 56.45% 56.45%
=======================================
Files 906 906
Lines 58115 58115
Branches 4226 4226
=======================================
Hits 32810 32810
Misses 25195 25195
Partials 110 110
🚀 New features to boost your workflow:
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit, but lgtm
.../src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/erc20/erc20.tsx
Outdated
Show resolved
Hide resolved
c863047
to
8973174
Compare
9f747e3
to
ccb8716
Compare
ccb8716
to
c76c372
Compare
<!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refining the UI components and enhancing the functionality of the `ERC20` public page. It includes improvements in layout, styling, and the introduction of new features related to token price data and analytics. ### Detailed summary - Deleted unused files: `useTokenPriceData.ts` and `ContractCreatorBadge.tsx`. - Updated `PageHeader` to change border style. - Added `tooltip` prop in `CopyAddressButton`. - Changed API key usage in `fetchTokenInfoFromBridge`. - Enhanced `ThirdwebAreaChart` with better props handling. - Introduced `GridPattern` component for background. - Improved `RecentTransfers` UI and pagination buttons. - Updated `PriceChart` and `TokenStats` to directly use passed props for token price data. - Refactored `ContractHeaderUI` to improve layout and social link handling. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Introduced a customizable grid background pattern component for enhanced visual design. * Added support for displaying token price data and analytics on ERC20 public pages, including conditional rendering of token statistics. * Enabled tooltip customization for the copy address button. * **Bug Fixes** * The contract creator badge icon is now visible, and spacing between elements has been improved. * **Refactor** * Simplified and unified chart headers and analytics section layouts. * Streamlined fetching and handling of token price data with a new asynchronous function and removed the previous hook. * Improved layout and container styling across ERC20 and NFT public pages, including card backgrounds, borders, and spacing. * Adjusted component structures for better visual separation and consistency. * Removed the contract creator badge component and replaced it with a simpler contract owner link. * **Style** * Updated card and header styles for better visual hierarchy and clarity. * Enhanced recent transfers and contract header sections with improved padding, borders, and rounded corners. * Removed small shadow effects from cards and refined header background and border styles. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1fa2e96
to
9821b1e
Compare
<!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refining the UI components and enhancing the functionality of the `ERC20` public page. It includes improvements in layout, styling, and the introduction of new features related to token price data and analytics. ### Detailed summary - Deleted unused files: `useTokenPriceData.ts` and `ContractCreatorBadge.tsx`. - Updated `PageHeader` to change border style. - Added `tooltip` prop in `CopyAddressButton`. - Changed API key usage in `fetchTokenInfoFromBridge`. - Enhanced `ThirdwebAreaChart` with better props handling. - Introduced `GridPattern` component for background. - Improved `RecentTransfers` UI and pagination buttons. - Updated `PriceChart` and `TokenStats` to directly use passed props for token price data. - Refactored `ContractHeaderUI` to improve layout and social link handling. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Introduced a customizable grid background pattern component for enhanced visual design. * Added support for displaying token price data and analytics on ERC20 public pages, including conditional rendering of token statistics. * Enabled tooltip customization for the copy address button. * **Bug Fixes** * The contract creator badge icon is now visible, and spacing between elements has been improved. * **Refactor** * Simplified and unified chart headers and analytics section layouts. * Streamlined fetching and handling of token price data with a new asynchronous function and removed the previous hook. * Improved layout and container styling across ERC20 and NFT public pages, including card backgrounds, borders, and spacing. * Adjusted component structures for better visual separation and consistency. * Removed the contract creator badge component and replaced it with a simpler contract owner link. * **Style** * Updated card and header styles for better visual hierarchy and clarity. * Enhanced recent transfers and contract header sections with improved padding, borders, and rounded corners. * Removed small shadow effects from cards and refined header background and border styles. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
9821b1e
to
6bf5dfb
Compare
<!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refining the UI components and enhancing the functionality of the `ERC20` public page. It includes improvements in layout, styling, and the introduction of new features related to token price data and analytics. ### Detailed summary - Deleted unused files: `useTokenPriceData.ts` and `ContractCreatorBadge.tsx`. - Updated `PageHeader` to change border style. - Added `tooltip` prop in `CopyAddressButton`. - Changed API key usage in `fetchTokenInfoFromBridge`. - Enhanced `ThirdwebAreaChart` with better props handling. - Introduced `GridPattern` component for background. - Improved `RecentTransfers` UI and pagination buttons. - Updated `PriceChart` and `TokenStats` to directly use passed props for token price data. - Refactored `ContractHeaderUI` to improve layout and social link handling. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Introduced a customizable grid background pattern component for enhanced visual design. * Added support for displaying token price data and analytics on ERC20 public pages, including conditional rendering of token statistics. * Enabled tooltip customization for the copy address button. * **Bug Fixes** * The contract creator badge icon is now visible, and spacing between elements has been improved. * **Refactor** * Simplified and unified chart headers and analytics section layouts. * Streamlined fetching and handling of token price data with a new asynchronous function and removed the previous hook. * Improved layout and container styling across ERC20 and NFT public pages, including card backgrounds, borders, and spacing. * Adjusted component structures for better visual separation and consistency. * Removed the contract creator badge component and replaced it with a simpler contract owner link. * **Style** * Updated card and header styles for better visual hierarchy and clarity. * Enhanced recent transfers and contract header sections with improved padding, borders, and rounded corners. * Removed small shadow effects from cards and refined header background and border styles. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
6bf5dfb
to
cdc7d95
Compare
PR-Codex overview
This PR primarily focuses on enhancing the
ERC20
public page and its components by improving layout, adding token price data fetching, and refining UI elements for better usability and aesthetics.Detailed summary
useTokenPriceData.ts
andContractCreatorBadge.tsx
.PageHeader
to change border style.tooltip
prop inCopyAddressButton
.fetchTokenInfoFromBridge
to useDASHBOARD_THIRDWEB_SECRET_KEY
.getTokenPriceData
for fetching token price data.ERC20PublicPage
to include token price data.ContractHeaderUI
layout and added social links.TokenStats
to use fetched token price data instead of local state.RecentTransfers
andPriceChartUI
.Summary by CodeRabbit
New Features
Refactor
Style