Skip to content

[TOOL-5083] Portal: Fix header on mobile viewport #7661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Jul 21, 2025


PR-Codex overview

This PR focuses on enhancing the UI components and layout of the application, improving the styling and structure of several elements, and optimizing imports and functionality in various files.

Detailed summary

  • Updated codecov.yml to manage coverage reporting paths.
  • Modified DocSearch.tsx to change button styling and structure.
  • Enhanced DocLayout.tsx with a utility function for class names.
  • Cleaned up Header.tsx by removing unused router logic and adjusting button structures for better navigation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Style

    • Improved visual styling of the header, navigation links, and GitHub icon for better responsiveness and clarity.
    • Updated the "Search Docs" button and keyboard shortcut hint with enhanced background and text styling.
  • Refactor

    • Simplified navigation in the header by replacing imperative routing with declarative link components.
    • Standardized class name composition in the documentation layout for improved code consistency.
  • Chores

    • Cleaned up whitespace in code coverage configuration.

@vercel vercel bot temporarily deployed to Preview – wallet-ui July 21, 2025 17:34 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 21, 2025 17:34 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www July 21, 2025 17:34 Inactive
Copy link

vercel bot commented Jul 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 5:50pm
nebula ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 5:50pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 5:50pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 5:50pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 5:50pm

Copy link

linear bot commented Jul 21, 2025

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 21, 2025 17:34 Inactive
Copy link

changeset-bot bot commented Jul 21, 2025

⚠️ No Changeset found

Latest commit: 29717b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jul 21, 2025

Walkthrough

The changes update navigation in the portal header from imperative routing to declarative Link components, restyle various header and navigation elements, and refine DocSearch and DocLayout component class name handling for improved consistency and appearance. No exported function signatures or public APIs were changed.

Changes

File(s) Change Summary
apps/portal/src/app/Header.tsx Replaced useRouter and router.push navigation with Link components; restyled header, navigation links, and icons.
apps/portal/src/components/Layouts/DocLayout.tsx Switched from clsx to local cn utility for className composition; no structural or logic changes.
apps/portal/src/components/others/DocSearch.tsx Updated button and shortcut hint styling; wrapped button text in <span>; minor visual changes only.
codecov.yml Removed trailing whitespace lines; no functional changes.

Estimated code review effort

2 (~15 minutes)

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6d85b35 and 29717b3.

📒 Files selected for processing (4)
  • apps/portal/src/app/Header.tsx (6 hunks)
  • apps/portal/src/components/Layouts/DocLayout.tsx (2 hunks)
  • apps/portal/src/components/others/DocSearch.tsx (1 hunks)
  • codecov.yml (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • codecov.yml
🚧 Files skipped from review as they are similar to previous changes (3)
  • apps/portal/src/components/others/DocSearch.tsx
  • apps/portal/src/components/Layouts/DocLayout.tsx
  • apps/portal/src/app/Header.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Size
  • GitHub Check: Build Packages
  • GitHub Check: Unit Tests
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Jul 21, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review July 21, 2025 17:34
@MananTank MananTank requested review from a team as code owners July 21, 2025 17:34
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.40%. Comparing base (ecf6dbf) to head (29717b3).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7661   +/-   ##
=======================================
  Coverage   56.40%   56.40%           
=======================================
  Files         908      908           
  Lines       58228    58228           
  Branches     4226     4226           
=======================================
  Hits        32844    32844           
  Misses      25274    25274           
  Partials      110      110           
Flag Coverage Δ
packages 56.40% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jul 21, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.23 KB (0%) 1.3 s (0%) 283 ms (+260.13% 🔺) 1.6 s
thirdweb (cjs) 353.45 KB (0%) 7.1 s (0%) 765 ms (+23.41% 🔺) 7.9 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 125 ms (+2158.41% 🔺) 239 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 53 ms (+2643.21% 🔺) 63 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 115 ms (+960.17% 🔺) 506 ms

@joaquim-verges joaquim-verges merged commit 8133fab into main Jul 21, 2025
29 checks passed
@joaquim-verges joaquim-verges deleted the tool-5083 branch July 21, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants