[SDK] Handle mobile deeplinks for WalletConnect transactions #7775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: fc515f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughA new changeset file was added to document a patch update for the "thirdweb" package, describing new WalletConnect mobile deeplink handling. Separately, a test in the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🧰 Additional context used📓 Path-based instructions (3)**/*.{ts,tsx}📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
**/*.test.{ts,tsx}📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
**/*.{ts,tsx,js,jsx}📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
🧠 Learnings (12)📓 Common learnings📚 Learning: applies to packages/thirdweb/src/wallets/** : eip-1193, eip-5792, eip-7702 standard support in walle...Applied to files:
📚 Learning: applies to packages/thirdweb/src/wallets/** : support for in-app wallets (social/email login)...Applied to files:
📚 Learning: surface breaking changes prominently in pr descriptions...Applied to files:
📚 Learning: applies to packages/thirdweb/src/wallets/** : smart wallets with account abstraction...Applied to files:
📚 Learning: applies to packages/thirdweb/src/wallets/** : unified `wallet` and `account` interfaces in wallet ar...Applied to files:
📚 Learning: applies to **/*.test.{ts,tsx} : keep tests deterministic and side-effect free...Applied to files:
📚 Learning: applies to src/exports/react.native.ts : react native specific exports are in `src/exports/react.nat...Applied to files:
📚 Learning: applies to **/*.test.{ts,tsx} : use real function invocations with stub data in tests; avoid brittle...Applied to files:
📚 Learning: the thirdwebbarchart component in apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(side...Applied to files:
📚 Learning: applies to **/*.test.{ts,tsx} : use mock service worker (msw) for fetch/http call interception in te...Applied to files:
📚 Learning: in react image components, conditional rendering of the entire image container (e.g., `{props.image ...Applied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
🔇 Additional comments (1)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7775 +/- ##
==========================================
- Coverage 56.37% 56.37% -0.01%
==========================================
Files 904 905 +1
Lines 58735 58760 +25
Branches 4137 4141 +4
==========================================
+ Hits 33113 33127 +14
- Misses 25517 25528 +11
Partials 105 105
🚀 New features to boost your workflow:
|
joaquim-verges
deleted the
_SDK_Handle_mobile_deeplinks_for_WalletConnect_transactions
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on handling mobile deeplinks for transactions via
WalletConnectand modifies a test case in theMediaRenderercomponent.Detailed summary
thirdwebto handle mobile deeplinks for transactions viaWalletConnect.MediaRenderer.test.tsxby skipping the test for rendering unknown content when nothing is found.Summary by CodeRabbit
Chores
Tests