Skip to content

Fix null reference exception in Util script. #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

jeffgamedev
Copy link
Contributor

  • Do not access string method if string value is null.

The case is a null string is passed to this utility method, and the utility method calls a method on this null object, resulting in a runtime null reference exception.

@0xFirekeeper
Copy link
Member

lgtm, ty!

@0xFirekeeper 0xFirekeeper merged commit 96bbd20 into thirdweb-dev:main Jun 20, 2023
@jeffgamedev jeffgamedev deleted the fix/null-ref-ipfs branch June 20, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants