Skip to content

Fix WalletConnect GameObject runtime error. #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jeffgamedev
Copy link
Contributor

Fix game object attempting to start coroutine when game object is not active in hierarchy.

After connecting to a wallet with WalletConnect, if the application loses focus, and then resumes focus, WalletConnect attempts to start a coroutine to generate a QR code, however the UI is not active and the start coroutine call fails in a runtime error. This change checks if the game object is active before starting the coroutine.

I've tested that WalletConnect is able to properly connect to a wallet after logging out of a wallet and using again.

@0xFirekeeper
Copy link
Member

I think this might break mobile behavior, async is not so fun in the editor but might be needed on such platforms, have you tested on Android?

@jeffgamedev
Copy link
Contributor Author

I think this might break mobile behavior, async is not so fun in the editor but might be needed on such platforms, have you tested on Android?

I have not tested on Android, only in editor.

@0xFirekeeper
Copy link
Member

We're in the process of updating WalletConnect to V2 so will merge this for now since QR is not going to be shown on mobile in most cases, ty ser

@0xFirekeeper 0xFirekeeper merged commit f76aa10 into thirdweb-dev:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants