Skip to content

Conversation

karilaa-dev
Copy link

No description provided.

@thiswillbeyourgithub
Copy link
Owner

Interesting thanks.

I'd like the following before merging:

  • Can you make it match model ids OR model names ? Users could get confused
  • make it regex matching instead of string matching. Still comma separated
  • make it so that "empty" or "none" deactivates this filtering mechanism. And "all" or "any" matches all of them.
  • mention clearly that this filteting only applies to whicheveg model has this filter enabled.

What do you think?

@thiswillbeyourgithub
Copy link
Owner

Don't you think an include filter is as useful as an exclude filter actually?
And filtering by user id/mail too

@karilaa-dev
Copy link
Author

Can you make it match model ids OR model names ? Users could get confused

Yup, I will mention that it uses model ids.

make it regex matching instead of string matching. Still comma separated

I'm not strong with regex, but I'll try implementing it.

make it so that "empty" or "none" deactivates this filtering mechanism. And "all" or "any" matches all of them.

I think best way for this is to add toggle for enabling this filter globally.
So if toggle is enabled models in list will NOT be filtered, and if disabled it will filter only models in list. From my use case I only have couple models I want to limit.

mention clearly that this filteting only applies to whicheveg model has this filter enabled.

And more details for that of course

And filtering by user id/mail too

Yeah, it's better, because I think no one stop user from changing nickname to an admin one.
As alternative, we can replace it with a toggle "Skip Admins"

@thiswillbeyourgithub
Copy link
Owner

Ahh, a good catch, I had not thought about admin status, but now that I think of it, we have access to the role of users too. So I'm thinking maybe we should go all the way and add a field to filter models, another field to filter users, another field to filter user groups. This would fill the void left by openwebui's not so redtrictive settings maybe.
Always based on comma separated regex. Llms mastered them if you need

@thiswillbeyourgithub
Copy link
Owner

And thanks a lot for contributing. I really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants