Skip to content

Allow for override of gui external runner #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Attamusc
Copy link

I've been using vim-rspec for a while and it's awesome, but the recent update to allow for both g:rspec_runner and g:rspec_command breaks my current workflow that I think others might also have: MacVim and tmux. Currently, all commands when run in gui vim are executed using the configured runner. This means that, even with a custom command, gui vim will not be able to execute anything inside of vim to externally run the command.

I added a global variable that allows the user to explicitly state if they do or do not want to use a runner script. This variable is set to true by default so that the current behavior without setting either rspec_command or rspec_runner remains the same.

While I don't think this is necessarily the best way to do this, it is "a way" and it requires minimal change. If there is a better way to do this, please let me know; if not, I'd be happy to also update the README with references to this variable.

@gylaz
Copy link
Contributor

gylaz commented Oct 3, 2014

What is your use case that you don't want to use an rspec_runner with GUI vim?

@Attamusc
Copy link
Author

Attamusc commented Oct 3, 2014

I currently have a set up like in this article, where vim-rspec is set up to pipe the command to tmux using tslime.vim

@gylaz
Copy link
Contributor

gylaz commented May 23, 2015

@Attamusc I've opened #94 which should address this. Do you mind trying that branch to see if it solves your problem?

@Attamusc Attamusc closed this Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants