Skip to content

Conversation

kpyszkowski
Copy link
Contributor

Ref: #1
This pull request removes "Feedback" page and related components.

Removed pages, `useAnalytics` hook, `AnalyticsModal` and
`FeedbackSubmissionModal`, `FeedbackAnalyticsInfo`,
`FeedbackRoutesButton` and `AnalyticsBanner` components
@kpyszkowski kpyszkowski marked this pull request as draft November 29, 2023 16:32
@kpyszkowski kpyszkowski self-assigned this Nov 29, 2023
@kpyszkowski kpyszkowski marked this pull request as ready for review December 11, 2023 15:20
Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grate job overall! 🔥 Left some comments to look at before the merge.

Let's also resolve the conflicts with main branch.

Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalsmiarowski michalsmiarowski merged commit 8fbb8c1 into main Jan 10, 2024
michalsmiarowski added a commit that referenced this pull request Jan 15, 2024
"Main" branch clean-up

Ref: #1 
Depends on: #7 #8 #10 #11 

This pull request aggregates each partial clean-up PR (mentioned above). It's
introduced to reduce complexity of merge conflicts and allow continuous work
without blocking while waiting for partial PRs to be merged.
Moreover it's a place for general cleanup commits that couldn't be addressed to
any of the PRs.
@michalsmiarowski michalsmiarowski mentioned this pull request Jan 15, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants