Fix #175: Cannot call #fields.detailedErrors() from a Spring Webflow form #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Webflow form In spring-webflow 2.3.1's org.springframework.webflow.mvc.view.BindingModel.getFieldErrors(java.lang.String) "*" leads to the error that a non-empty prefix is expected; calling the parameter-less version works as expected.
… a Spring Webflow form In spring-webflow 2.3.1's org.springframework.webflow.mvc.view.BindingModel.getFieldErrors(java.lang.String) "*" leads to the error that a non-empty prefix is expected; calling the parameter-less version works as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
#fields.detailedErrors()with spring-webflow 2.3.1 will call its org.springframework.webflow.mvc.view.BindingModel.getFieldErrors(java.lang.String) with "" as argument. However specifing "" leads to the error that a non-empty prefix is expected; calling the parameter-less version works as expected.I checked back into the repository and the behaviour is unchanged since 2.3.1:
getFieldErrors(java.lang.String)delegates callsnew FieldPrefixErrorMessage(String)when the input ends in *, removing the last characternew FieldPrefixErrorMessage(String)then asserts that a non-empty prefix is given, which will result in an exception as the only character was removed.Feel free to propose another fix, but from what I see in spring-webflow's BindingModel there are not many other approaches. Probably calling
getAllErrors()would also be an option, too.