Skip to content

Rename predict(.time =) to predict(time =) #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2021
Merged

Conversation

DavisVaughan
Copy link
Member

@DavisVaughan DavisVaughan commented May 17, 2021

Joint PR with tidymodels/censored#56 (merge this parsnip one first)

This PR renames the .time argument of predict() to time. This is more consistent with our other arguments that get passed through the dots, like level and quantile.

@DavisVaughan DavisVaughan requested a review from topepo May 17, 2021 20:13
@topepo topepo merged commit 87c0865 into master May 18, 2021
@topepo topepo deleted the feature/dot-time-to-time branch May 18, 2021 12:03
DavisVaughan added a commit to DavisVaughan/censored that referenced this pull request May 18, 2021
@github-actions
Copy link

github-actions bot commented Jun 2, 2021

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants