Skip to content

temporarily mark survival models as internal #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2021

Conversation

topepo
Copy link
Member

@topepo topepo commented May 18, 2021

Until censored is fully operational

@topepo topepo requested a review from hfrick May 18, 2021 14:08
@hfrick
Copy link
Member

hfrick commented May 18, 2021

We soft-deprecated surv_reg(), i.e. it now gives a warning and tells you to use survival_reg(), the help file including examples points to the new function, and the help file itself is now also internal. So I'd say we either undo all of that or we don't make survival_reg() internal.

Are we also adapting the news file?

@juliasilge
Copy link
Member

I do think we should take this out of the NEWS file and put it back in after it goes to CRAN, for the next release.

@topepo
Copy link
Member Author

topepo commented May 18, 2021

I've update the news file in the RC branch.

I think the message is ok. It's not removed, just not listed (easily) in the help.

@hfrick
Copy link
Member

hfrick commented May 18, 2021

okay sure, it just means that in this branch neither surv_reg() nor survival_reg() are listed in the documentation index. if you think that's fine then I have no more comments on this one 👍

@topepo topepo merged commit adf0f32 into master May 18, 2021
@topepo topepo deleted the censored-keyword-internal branch May 18, 2021 21:32
@github-actions
Copy link

github-actions bot commented Jun 2, 2021

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants