-
Notifications
You must be signed in to change notification settings - Fork 2.1k
theme_void() does not remove grids #2079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
has2k1
added a commit
to has2k1/ggplot2
that referenced
this issue
Mar 20, 2017
**Issue** At plot time, the calculation of theme elements always fell back to the default theme. As a consequence, the default theme would leak into complete themes where some of the elements were unspecified. **Solution** Be more specific when calculating the theme defaults. **Clean Up** `theme_void` was insufficiently specified. The solution exposed missing elements that had to be specified. Fixes tidyverse#2058 Fixes tidyverse#2079
has2k1
added a commit
to has2k1/ggplot2
that referenced
this issue
Jul 3, 2017
**Issue** At plot time, the calculation of theme elements always fell back to the default theme. As a consequence, the default theme would leak into complete themes where some of the elements were unspecified. **Solution** Be more specific when calculating the theme defaults. **Clean Up** `theme_void` was insufficiently specified. The solution exposed missing elements that had to be specified. Fixes tidyverse#2058 Fixes tidyverse#2079
has2k1
added a commit
to has2k1/ggplot2
that referenced
this issue
Jul 14, 2017
**Issue** At plot time, the calculation of theme elements always fell back to the default theme. As a consequence, the default theme would leak into complete themes where some of the elements were unspecified. **Solution** Be more specific when calculating the theme defaults. **Clean Up** `theme_void` was insufficiently specified. The solution exposed missing elements that had to be specified. Fixes tidyverse#2058 Fixes tidyverse#2079
has2k1
added a commit
to has2k1/ggplot2
that referenced
this issue
Aug 1, 2017
**Issue** At plot time, the calculation of theme elements always fell back to the default theme. As a consequence, the default theme would leak into complete themes where some of the elements were unspecified. **Solution** Be more specific when calculating the theme defaults. **Clean Up** `theme_void` was insufficiently specified. The solution exposed missing elements that had to be specified. Fixes tidyverse#2058 Fixes tidyverse#2079
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When using a custom grid,
theme_void
does not remove it. Here is a simple example illustrating it:Given that
theme_void
is supposed to be a completely empty theme, I thinktheme_void
should redefine all elements toelement_blank()
, includingpanel.grid.major
andpanel.grid.minor
, and probably others (I believe it is somehow related to #2058, in the sense thattheme_void
should redefine more elements than it currently does).The text was updated successfully, but these errors were encountered: