You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To me it feels counter intuitive that NULL is a no-op while list() results in a modified object. Of course the rendered plots do not differ. In the current definition of function add_ggplot() the test for returning p unchanged uses is.null(object), one could use length(object) == 0 instead, but maybe it is just me that is surprised, and there is a good reason behind treating NULL and list() differently.
To me it feels counter intuitive that
NULL
is a no-op whilelist()
results in a modified object. Of course the rendered plots do not differ. In the current definition of functionadd_ggplot()
the test for returningp
unchanged usesis.null(object)
, one could uselength(object) == 0
instead, but maybe it is just me that is surprised, and there is a good reason behind treatingNULL
andlist()
differently.The text was updated successfully, but these errors were encountered: