Skip to content

Clarify documentation in mpg: very minor #3477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaraAlexeev opened this issue Aug 7, 2019 · 3 comments · Fixed by #3515
Closed

Clarify documentation in mpg: very minor #3477

MaraAlexeev opened this issue Aug 7, 2019 · 3 comments · Fixed by #3515

Comments

@MaraAlexeev
Copy link
Contributor

I was working through exercises using mpg in ggplot2 Elegant Graphics for Data Analysis, and I got stuck on trying to figure out what a drive train was.

I finally realized the variable drv means drive train. Could the documentation be updated to identify drv as meaning drive train?

Currently:
drv f = front-wheel drive, r = rear wheel drive, 4 = 4wd

Suggested:
drv the type of drive train, where f = front-wheel drive, r = rear wheel drive, 4 = 4wd

@yutannihilation
Copy link
Member

yutannihilation commented Aug 17, 2019

Thanks, sounds good to me. Do you want to try to create a pull request? You need to modify R/data.R and regenerate the doc by devtools::document().

#' \item{drv}{f = front-wheel drive, r = rear wheel drive, 4 = 4wd}

@MaraAlexeev
Copy link
Contributor Author

MaraAlexeev commented Aug 17, 2019 via email

@lock
Copy link

lock bot commented Mar 10, 2020

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants