Fix theme_gray's legend/panels for large base_size #2145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently theme_gray's legend and background panels don't work well at base_size=24 or base_size=30 because their sizes are hardcoded in. If we make them relative, then theme_gray looks nice at larger base_size's.
|
Hi, any input on this? The conflicts appear to be due to the tests not allowing changes to the default themes, which is the point of this PR... |
|
@karawoo I've already forgotten what other changes we made. Can you please comment as to whether this is still necessary? |
|
This is still necessary but I think it should wait until I add the |
|
👍 |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently theme_gray's legend and background panels don't work well at base_size=24 or base_size=30 because their sizes are hardcoded in. If we make them relative, then theme_gray looks nice at larger base_size's.