Skip to content

Swap order of preserve arguments in position_dodge2() #2545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2018

Conversation

karawoo
Copy link
Member

@karawoo karawoo commented Apr 29, 2018

#2386 made preserve = "total" the default for PositionDodge2, but didn't swap the order of the defaults in position_dodge2(). This fixes it.

@karawoo karawoo requested a review from hadley April 29, 2018 21:46
@hadley hadley merged commit e6311f2 into tidyverse:master Apr 30, 2018
@hadley
Copy link
Member

hadley commented Apr 30, 2018

Thanks!

@lock
Copy link

lock bot commented Oct 27, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Oct 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants