Fix incorrect monotonicity test failure in sec.axis #2805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure is due to an invertibility issue in scales 0.5.0 |
|
@thomasp85 can you please review? |
|
Yes - I’ll give it a look tomorrow |
thomasp85
approved these changes
Aug 10, 2018
This was referenced Nov 14, 2018
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2095 changed the order in which the range a secondary axis was transformed, sampled, and tested for monotonicity. Sampling over the transformed space rather than the original scale caused the monotonicity test on the secondary axis to fail for certain transformations. This PR fixes those failures by sampling on the original scale rather than the transformed scale, effectively a partial reversal of PR #2095 whose motivating problem was fixed in an alternative way by #2796.