Skip to content

Document mapping arg to geom_abline() without mentioning inherit.aes #3173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2019
Merged

Document mapping arg to geom_abline() without mentioning inherit.aes #3173

merged 1 commit into from
Mar 5, 2019

Conversation

karawoo
Copy link
Member

@karawoo karawoo commented Mar 5, 2019

Fixes #2696

@karawoo karawoo requested a review from yutannihilation March 5, 2019 00:02
yutannihilation
yutannihilation approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@yutannihilation yutannihilation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@karawoo karawoo merged commit c2d489c into tidyverse:master Mar 5, 2019
@lock
Copy link

lock bot commented Sep 1, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yutannihilation yutannihilation yutannihilation approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inherit.aes ignored in geom_{ab,h,v}line
2 participants
@karawoo @yutannihilation