Update visual cases #3638
Merged
Update visual cases #3638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutannihilation
commented
Nov 24, 2019
There was a problem hiding this comment.
Sorry, I don't know how to share the visual diffs. So, I copied data:image/png;base64,... part from the diff into a HTML file and viewed it on browser. They looks the same to my eyes.
<html>
<head>
<style>
img {
width: 100px;
}
</style>
</head>
<body>
<img src='data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABIAAABXCAYAAAAJWxWIAAAABmJLR0QA/wD/AP+gvaeTAAABjUlEQVRYhc2Yy3EdMRADG9SUHZsjcVzKyZH4YFtLcqDDcwaDgzaArh6Any3qnHcz/Oz+Udr/phwsEwGVobQ/xiCA4pkbYVEkjCSKQEa4QyCcygiKE8jIhEaTQqPRFPvvnCNCIJtyACSJ8vNnDLpAsX+PQQiqEyBDeX9PCFF9vs2NJMq75hxDdQBkoPq8zY1erc1BWJQDILGo3msutKD6zEFqZUDYVD9z0JIoB4xOm+pHY5AUau2V0Z4bLd4yoF5kWjOmzk2AoPYNnUe3A61JISOJOgGjtqlz5+eRbep0ACSoHTASZDKSO5PRWitj5A7VbzsTNsuhsFvUjuz+kJFXakG2qOPALXKhdo85rxPyBEA4ZCSFjNbLaB62ZeqM3yGA/moZdao1BLUDGanJhL1IjbZSo53Upk2FTUM9KaPDnZNY1FnPnGNRlwAIqKMAaHXKSNQNGBkyRq+blv11jBpTxwEjieqA0f+f0bmRENV9xiCWqJvI6Jg6dw7Cop4OLEhBfXTgzd+itvfPMYn96xMzVA/gKz5U8AAAAABJRU5ErkJggg=='/>
<img src='data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABIAAABXCAYAAAAJWxWIAAAABmJLR0QA/wD/AP+gvaeTAAABjUlEQVRYhc2YwZUVMQwEq716EBuRENfmRCQcgB3b6j18MlAfdgKoV2rJ8jzrnHcz/Oz+Udr/phwsEwGVobQ/xiCA4pkbYVEkjCSKQEa4QyCcygiKE8jIhEqTQqXRFPvvnCNCIJtyACSJ8vNnDLpAsX+PQQiqEyBDeX9PCFF9vs2NJMq75hxDdQBkoPq8zY1eXZuDsCgHQGJRvddcaEH1mYPUyoCwqX7moCVRDhidNtWPxiAp1LVXRntutHjLgHqR6ZoxdW4CBLVvaB/dDnRNChlJ1AkYtU2dO99HtqnTAZCgdsBIkMlI7kxGa62MkTvUftuZsFkOhd2iduT0h4y8UgPZoo4Dt8iF2j3mvDbkCYBwyEgKGa2X0Txsy9QZv0MA/dUyakPtRGmkSjOZsBchI1YoI53UoVWqa6mBbEFt7pzEos565hyLugRAQB0FQKtTRqJuwMiQMXrdtOyvY9SYOg4YSVQHjP7/jM6NhKjuMwaxRN1ERsfUuXMQFvV0YCAF9dGBN3+L2t4/xyT2r08udw/fYGKV5AAAAABJRU5ErkJggg=='/>
<br />
<img src='data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABIAAABXCAYAAAAJWxWIAAAABmJLR0QA/wD/AP+gvaeTAAABE0lEQVRYhc2YwRHDMAgEF4Q9frmvVJKGUw/k4RK8D7kAzbHHCeSYM4a3X8ynuOv1OcRQXOf7g4DiEhTNUJxWaceSFB2WohIUhaVohmIJihiKSuGcoCijtKBYhiLLNQ32YLmGxCiSYhkRsVzL7WB7rlmMsBjFUOROjAaKNDq7d4tIW6VlWPanpOix35priv0ao7AYjcQIjZEV2gzpGsFyjZYYdUqlaYy0zm4r/YlVmtWQbcHe9KpVsmYdpDEa7RppqzTLNawBibVEPOkXFKU1IMPaalvrbG0ZtWCPC9uw39pGQGIUlmvjbiPaFNGeWTuN7LAuf22KeLC1XxrWcz2srGnvNSzX2gptWqHF6qN+7P8Kgn5/vNJD8shvDpsAAAAASUVORK5CYII='/>
<img src='data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABIAAABXCAYAAAAJWxWIAAAABmJLR0QA/wD/AP+gvaeTAAABGklEQVRYhc3Yy3XDUAgE0AFhJ6v0lUrScOp5eOESdBdWAZxhPsBT7bM2d7/a38nP3K6T2ky+n/cLJZl8AURZVKg2k8cFAG0mD4VoAKJSiHYzufp+oSSTC7SWUqo1QvTmSLTGCgX5KEHyV2dyiYgUQtSK7FUcbSGOUpm0UI3OI4GIcbRRHB0aEUD2qUwaFOpCiKqV/GqLvOUXrTGOVGjdOmIcKdVacZTNpMU6Uuk/LUP7Uc4+Kv39cYY8ypCtDNmK7LCDXanG1tGqiOSo1qxq4oZU95EbbKvSrxbkYc5mx2ijMbL0CSEM2eoJEXr6iUKrBhubR6VC6+5stY6sap9FNvulwUZt1Dxi6VeqHRXaVqGN8tF5y/8HAP2/AM7iPvzuGKsSAAAAAElFTkSuQmCC'/>
<br/>
<img src='data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABIAAABXCAYAAAAJWxWIAAAABmJLR0QA/wD/AP+gvaeTAAABE0lEQVRYhc2YwRHDMAgEF4Q9frmvVJKGUw/k4RK8D7kAzbHHCeSYM4a3X8ynuOv1OcRQXOf7g4DiEhTNUJxWaceSFB2WohIUhaVohmIJihiKSuGcoCijtKBYhiLLNQ32YLmGxCiSYhkRsVzL7WB7rlmMsBjFUOROjAaKNDq7d4tIW6VlWPanpOix35priv0ao7AYjcQIjZEV2gzpGsFyjZYYdUqlaYy0zm4r/YlVmtWQbcHe9KpVsmYdpDEa7RppqzTLNawBibVEPOkXFKU1IMPaalvrbG0ZtWCPC9uw39pGQGIUlmvjbiPaFNGeWTuN7LAuf22KeLC1XxrWcz2srGnvNSzX2gptWqHF6qN+7P8Kgn5/vNJD8shvDpsAAAAASUVORK5CYII='/>
<img src='data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABIAAABXCAYAAAAJWxWIAAAABmJLR0QA/wD/AP+gvaeTAAABGklEQVRYhc3Yy3XDUAgE0AFhJ6v0lUrScOp5eOESdBdWAZxhPsBT7bM2d7/a38nP3K6T2ky+n/cLJZl8AURZVKg2k8cFAG0mD4VoAKJSiHYzufp+oSSTC7SWUqo1QvTmSLTGCgX5KEHyV2dyiYgUQtSK7FUcbSGOUpm0UI3OI4GIcbRRHB0aEUD2qUwaFOpCiKqV/GqLvOUXrTGOVGjdOmIcKdVacZTNpMU6Uuk/LUP7Uc4+Kv39cYY8ypCtDNmK7LCDXanG1tGqiOSo1qxq4oZU95EbbKvSrxbkYc5mx2ijMbL0CSEM2eoJEXr6iUKrBhubR6VC6+5stY6sap9FNvulwUZt1Dxi6VeqHRXaVqGN8tF5y/8HAP2/AM7iPvzuGKsSAAAAAElFTkSuQmCC'/>
</body>
</html>| @@ -51,7 +51,7 @@ | |||
| <g clip-path='url(#cpMC4wMHw3MjAuMDB8NTc2LjAwfDAuMDA=)'><text x='349.15' y='568.24' style='font-size: 11.00px; font-family: Liberation Sans;' textLength='5.50px' lengthAdjust='spacingAndGlyphs'>x</text></g> | |||
| <g clip-path='url(#cpMC4wMHw3MjAuMDB8NTc2LjAwfDAuMDA=)'><text transform='translate(13.04,286.70) rotate(-90)' style='font-size: 11.00px; font-family: Liberation Sans;' textLength='5.50px' lengthAdjust='spacingAndGlyphs'>x</text></g> | |||
| <rect x='679.54' y='233.09' width='34.98' height='101.72' style='stroke-width: 1.07; stroke: none; fill: #FFFFFF;' clip-path='url(#cpMC4wMHw3MjAuMDB8NTc2LjAwfDAuMDA=)' /> | |||
| <g clip-path='url(#cpMC4wMHw3MjAuMDB8NTc2LjAwfDAuMDA=)'><image width='17.28' height='86.40' x='679.54' y='248.41' xlink:href='data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABIAAABXCAYAAAAJWxWIAAAABmJLR0QA/wD/AP+gvaeTAAABE0lEQVRYhc2YwRHDMAgEF4Q9frmvVJKGUw/k4RK8D7kAzbHHCeSYM4a3X8ynuOv1OcRQXOf7g4DiEhTNUJxWaceSFB2WohIUhaVohmIJihiKSuGcoCijtKBYhiLLNQ32YLmGxCiSYhkRsVzL7WB7rlmMsBjFUOROjAaKNDq7d4tIW6VlWPanpOix35priv0ao7AYjcQIjZEV2gzpGsFyjZYYdUqlaYy0zm4r/YlVmtWQbcHe9KpVsmYdpDEa7RppqzTLNawBibVEPOkXFKU1IMPaalvrbG0ZtWCPC9uw39pGQGIUlmvjbiPaFNGeWTuN7LAuf22KeLC1XxrWcz2srGnvNSzX2gptWqHF6qN+7P8Kgn5/vNJD8shvDpsAAAAASUVORK5CYII='/></g> | |||
There was a problem hiding this comment.
left: before, right: after
| @@ -51,7 +51,7 @@ | |||
| <g clip-path='url(#cpMC4wMHw3MjAuMDB8NTc2LjAwfDAuMDA=)'><text x='349.15' y='568.24' style='font-size: 11.00px; font-family: Liberation Sans;' textLength='5.50px' lengthAdjust='spacingAndGlyphs'>x</text></g> | |||
| <g clip-path='url(#cpMC4wMHw3MjAuMDB8NTc2LjAwfDAuMDA=)'><text transform='translate(13.04,286.70) rotate(-90)' style='font-size: 11.00px; font-family: Liberation Sans;' textLength='5.50px' lengthAdjust='spacingAndGlyphs'>x</text></g> | |||
| <rect x='679.54' y='233.09' width='34.98' height='101.72' style='stroke-width: 1.07; stroke: none; fill: #FFFFFF;' clip-path='url(#cpMC4wMHw3MjAuMDB8NTc2LjAwfDAuMDA=)' /> | |||
| <g clip-path='url(#cpMC4wMHw3MjAuMDB8NTc2LjAwfDAuMDA=)'><image width='17.28' height='86.40' x='679.54' y='248.41' xlink:href='data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABIAAABXCAYAAAAJWxWIAAAABmJLR0QA/wD/AP+gvaeTAAABE0lEQVRYhc2YwRHDMAgEF4Q9frmvVJKGUw/k4RK8D7kAzbHHCeSYM4a3X8ynuOv1OcRQXOf7g4DiEhTNUJxWaceSFB2WohIUhaVohmIJihiKSuGcoCijtKBYhiLLNQ32YLmGxCiSYhkRsVzL7WB7rlmMsBjFUOROjAaKNDq7d4tIW6VlWPanpOix35priv0ao7AYjcQIjZEV2gzpGsFyjZYYdUqlaYy0zm4r/YlVmtWQbcHe9KpVsmYdpDEa7RppqzTLNawBibVEPOkXFKU1IMPaalvrbG0ZtWCPC9uw39pGQGIUlmvjbiPaFNGeWTuN7LAuf22KeLC1XxrWcz2srGnvNSzX2gptWqHF6qN+7P8Kgn5/vNJD8shvDpsAAAAASUVORK5CYII='/></g> | |||
There was a problem hiding this comment.
left: before, right: after
| @@ -51,7 +51,7 @@ | |||
| <g clip-path='url(#cpMC4wMHw3MjAuMDB8NTc2LjAwfDAuMDA=)'><text x='352.81' y='568.24' style='font-size: 11.00px; font-family: Liberation Sans;' textLength='5.50px' lengthAdjust='spacingAndGlyphs'>x</text></g> | |||
| <g clip-path='url(#cpMC4wMHw3MjAuMDB8NTc2LjAwfDAuMDA=)'><text transform='translate(13.04,286.70) rotate(-90)' style='font-size: 11.00px; font-family: Liberation Sans;' textLength='5.50px' lengthAdjust='spacingAndGlyphs'>y</text></g> | |||
| <rect x='686.87' y='233.09' width='27.65' height='101.72' style='stroke-width: 1.07; stroke: none; fill: #FFFFFF;' clip-path='url(#cpMC4wMHw3MjAuMDB8NTc2LjAwfDAuMDA=)' /> | |||
| <g clip-path='url(#cpMC4wMHw3MjAuMDB8NTc2LjAwfDAuMDA=)'><image width='17.28' height='86.40' x='686.87' y='248.41' xlink:href='data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABIAAABXCAYAAAAJWxWIAAAABmJLR0QA/wD/AP+gvaeTAAABjUlEQVRYhc2Yy3EdMRADG9SUHZsjcVzKyZH4YFtLcqDDcwaDgzaArh6Any3qnHcz/Oz+Udr/phwsEwGVobQ/xiCA4pkbYVEkjCSKQEa4QyCcygiKE8jIhEaTQqPRFPvvnCNCIJtyACSJ8vNnDLpAsX+PQQiqEyBDeX9PCFF9vs2NJMq75hxDdQBkoPq8zY1erc1BWJQDILGo3msutKD6zEFqZUDYVD9z0JIoB4xOm+pHY5AUau2V0Z4bLd4yoF5kWjOmzk2AoPYNnUe3A61JISOJOgGjtqlz5+eRbep0ACSoHTASZDKSO5PRWitj5A7VbzsTNsuhsFvUjuz+kJFXakG2qOPALXKhdo85rxPyBEA4ZCSFjNbLaB62ZeqM3yGA/moZdao1BLUDGanJhL1IjbZSo53Upk2FTUM9KaPDnZNY1FnPnGNRlwAIqKMAaHXKSNQNGBkyRq+blv11jBpTxwEjieqA0f+f0bmRENV9xiCWqJvI6Jg6dw7Cop4OLEhBfXTgzd+itvfPMYn96xMzVA/gKz5U8AAAAABJRU5ErkJggg=='/></g> | |||
There was a problem hiding this comment.
left:before, right: after
clauswilke
approved these changes
Nov 24, 2019
|
You can click this button — |
|
This is probably due to some subtly different calculation by farver |
Oh, thanks for this tips! (But, this time this doesn't work for me...) I'll try next time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems these are diffs about coloubar legends, though they doesn't seem different to my eyes.
The latest build passes (cb0eaa0) on 6 days ago, so I suspect this might be related to some update of scales.