Skip to content

remove NA breaks before creating the guides #3999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2020

Conversation

thomasp85
Copy link
Member

Fix #3876 This PR makes sure NA are not represented in the guide. Whether these guides (and colourbar) should actually represent NA (in a more aesthetically pleasing way) is a discussion for later when a guide rewrite is done

@thomasp85 thomasp85 added this to the ggplot2 3.3.1 milestone May 15, 2020
@thomasp85 thomasp85 requested a review from clauswilke May 15, 2020 09:38
@thomasp85 thomasp85 merged commit 908edc9 into tidyverse:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guide colorsteps creates an ugly, large NA box
2 participants