Skip to content

fix stat_function() regression #4016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2020

Conversation

clauswilke
Copy link
Member

library(RBesT)
#> Warning: package 'RBesT' was built under R version 3.6.2
#> Loading required package: Rcpp
#> This is RBesT version 1.6.0

## a beta mixture
bm <- mixbeta(weak=c(0.2, 2, 10), inf=c(0.4, 10, 100), inf2=c(0.4, 30, 80))

## extract the two most informative components
bm[[c(2,3)]]
#> Univariate beta mixture
#> Mixture Components:
#>   inf   inf2 
#> w   0.4   0.4
#> a  10.0  30.0
#> b 100.0  80.0
## rescaling needed in order to plot
plot(bm[[c(2,3),rescale=TRUE]])

Created on 2020-05-20 by the reprex package (v0.3.0)

@clauswilke clauswilke mentioned this pull request May 20, 2020
@clauswilke clauswilke requested a review from thomasp85 May 21, 2020 00:24
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasp85 thomasp85 added this to the ggplot2 3.3.1 milestone May 21, 2020
@clauswilke clauswilke merged commit 4826838 into tidyverse:master May 21, 2020
@clauswilke clauswilke deleted the stat_function_data branch May 21, 2020 14:54
@wds15
Copy link

wds15 commented May 27, 2020

I just discovered this... I am the author of RBesT. Is there anything I need to do on my side now? Should I change any of the code creating the plot in question here? Or is the matter resolved on your side?

Thanks for your advise.

EDIT: OK, I just installed the current dev version from git and now the annoying warnings go away. Thanks for handling this. Let me know if I should still do anything on my end.

@clauswilke
Copy link
Member Author

@wds15 You should be all set, but it wouldn't hurt to install the development version of ggplot2 and check RBesT against that.

@clauswilke
Copy link
Member Author

Ah, sorry, I see you just did that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants