Preserve NA
s in discrete palettes
#5949
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #5929.
Briefly, there are 3 situations by which a value can become
NA
in a discrete scale.NA
.NA
because a palette value isNA
.Currently, we cannot distinguish between situation (2) and situation (3).
This PR ensures that situation (1) and (2) are laundered through the
na.translate
/na.value
mechanism, but (3) is not because we could assume (3) is intentional by users (see issue).As a demo, notice that 'e' gets
NA
due to (3) and is subsequently removed, while 'r' getsna.value
due to (2).Created on 2024-06-19 with reprex v2.1.0