Skip to content

Clear merge debris (Re: #6416) #6432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 19, 2025
Merged

Conversation

teunbrand
Copy link
Collaborator

This PR re-implements #6416 on rectified main branch.

It largely shares the same goals:

  • Adds element_geom(), element_polygon() and element_point() to is_theme_element(type) options.
  • Consistently use the new is_*() functions.
  • Convert remaining internal is.*() functions to is_*() functions.

@teunbrand teunbrand mentioned this pull request Apr 16, 2025
@teunbrand teunbrand added this to the ggplot2 4.0.0 milestone May 6, 2025
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you may want to go over it extra carefully due to the recent hot fix release

@teunbrand
Copy link
Collaborator Author

Yeah this PR is build on top of the correctly merged hotfix release. The first attempt (#6416) was on the incorrectly merged state.

@thomasp85
Copy link
Member

sounds good

Merge branch 'main' into clear_merge_debris_2

# Conflicts:
#	R/scale-.R
@teunbrand teunbrand merged commit f340b1a into tidyverse:main May 19, 2025
13 checks passed
@teunbrand teunbrand deleted the clear_merge_debris_2 branch May 19, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants