revdepcheck 2025-05-20 #6469
Open
revdepcheck 2025-05-20 #6469
+19,588
−13,447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
reviewed
May 21, 2025
Comment on lines
+69
to
+75
| > library(sf) | ||
| Linking to GEOS 3.12.1, GDAL 3.8.4, PROJ 9.4.0; sf_use_s2() is TRUE | ||
| > bl = read_sf(adklakedata::adk_shape()) | ||
| Error in process_cpl_read_ogr(x, quiet, check_ring_dir = check_ring_dir, : | ||
| package tibble not available: install first? | ||
| Calls: read_sf ... st_read -> st_read.character -> process_cpl_read_ogr | ||
| Execution halted |
There was a problem hiding this comment.
We moved tibble to suggests (#5990), so it isn't automatically downloaded for reverse dependencies. This should be solved at their end by setting a tibble dependency, I think.
teunbrand
reviewed
May 21, 2025
Comment on lines
+306
to
+313
| 3. └─ggplot2:::scale_backward_compatibility(...) | ||
| 4. ├─rlang::exec(scale, !!!args) | ||
| 5. └─ggplot2 (local) `<fn>`(...) | ||
| 6. ├─ggplot2::discrete_scale(...) | ||
| 7. │ └─ggplot2::ggproto(...) | ||
| 8. │ └─rlang::list2(...) | ||
| 9. └─ggplot2:::pal_qualitative(type = type) | ||
| 10. └─ggplot2:::stop_input_type(type, "a character vector or list of character vectors") |
There was a problem hiding this comment.
Should look into stabilising scale_backward_compatibility()
teunbrand
reviewed
May 21, 2025
| > data(iris) | ||
| > bar_plot(iris) | ||
| Error in pm[[2]] : subscript out of bounds | ||
| Calls: bar_plot ... plotly_build -> ggplotly -> ggplotly.ggplot -> gg2list |
There was a problem hiding this comment.
Plotly errors are still common. I've thrown a PR their way, but it isn't on CRAN yet. Should check with the S7 conversion before they do.
teunbrand
reviewed
May 21, 2025
Comment on lines
+997
to
+1000
| ══ Failed tests ════════════════════════════════════════════════════════════════ | ||
| ── Failure ('test-dists.R:34:3'): Success ────────────────────────────────────── | ||
| plotNormalInvGamma(3, 1, 1, 1)$labels$y not equal to "sig_sq". | ||
| target is NULL, current is character |
There was a problem hiding this comment.
Typical case of #6290. About half of the PRs I had sent out aren't merged yet.
teunbrand
reviewed
May 21, 2025
Comment on lines
+1087
to
+1091
| ── Failure ('test-PPV_heatmap.R:1097:3'): Plot with line overlay ─────────────── | ||
| vapply(p$result$layers, function(x) class(x$geom)[1], "") (`actual`) not identical to c("GeomTile", "GeomSegment", "GeomPoint", "GeomMarkRect") (`expected`). | ||
|
|
||
| `names(actual)` is a character vector ('geom_tile', 'annotate', 'annotate...3', 'geom_mark_rect') | ||
| `names(expected)` is absent |
There was a problem hiding this comment.
Getting test failures for layers having names now (#5967). Should be harmless, but annoying that tests are broken.
teunbrand
reviewed
May 21, 2025
Comment on lines
+3635
to
+3641
| ══ Failed tests ════════════════════════════════════════════════════════════════ | ||
| ── Failure ('test-plot.R:50:3'): ggplot2 implementation works ────────────────── | ||
| `print(gg1)` produced warnings. | ||
| ── Failure ('test-plot.R:56:3'): ggplot2 implementation works ────────────────── | ||
| `print(gg3)` produced warnings. | ||
|
|
||
| [ FAIL 2 | WARN 14 | SKIP 0 | PASS 2766 ] |
There was a problem hiding this comment.
Expecting functions to be silent will break upon lifecycle changes. These should probably be snapshot tests on their end.
|
Here is an initial breakdown of the problems:
|
teunbrand
reviewed
May 22, 2025
Comment on lines
+889
to
+897
| 18. └─vctrs (local) `<fn>`() | ||
| 19. └─vctrs::vec_default_ptype2(...) | ||
| 20. ├─base::withRestarts(...) | ||
| 21. │ └─base (local) withOneRestart(expr, restarts[[1L]]) | ||
| 22. │ └─base (local) doWithOneRestart(return(expr), restart) | ||
| 23. └─vctrs::stop_incompatible_type(...) | ||
| 24. └─vctrs:::stop_incompatible(...) | ||
| 25. └─vctrs:::stop_vctrs(...) | ||
| 26. └─rlang::abort(message, class = c(class, "vctrs_error"), ..., call = call) |
There was a problem hiding this comment.
This is also a recurring error, it think it might be because vctrs is too strict. Or at least: people use the lack of strictness we had earlier.
This was referenced May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.