Bump jemalloc 0.6.0 #96
Open
+337
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tushar Mathur <[email protected]>
Signed-off-by: Jack Kleeman <[email protected]>
The configure step for jemalloc fails to recognize the rustc target `riscv64gc-unknown-linux-musl`: ``` --- stderr Invalid configuration `riscv64gc-unknown-linux-musl': machine `riscv64gc-unknown' not recognized configure: error: /bin/sh build-aux/config.sub riscv64gc-unknown-linux-musl failed thread 'main' panicked at /home/marv/.cargo/registry/src/index.crates.io-6f17d22bba15001f/jemalloc-sys-0.5.4+5.3.0-patched/build.rs:351:9: command did not execute successfully: cd "/mnt/data/devel/ripgrep/target/release/build/jemalloc-sys-eb3f9d51d93e319f/out/build" && CC="cc" CFLAGS="-O3 -ffunction-sections -fdata-sections -fPIC -gdwarf-4 -fno-omit-frame-pointer -march=rv64gc -mabi=lp64d -mcmodel=medany -Wall -g -ggdb3 -O0" CPPFLAGS="-O3 -ffunction-sections -fdata-sections -fPIC -gdwarf-4 -fno-omit-frame-pointer -march=rv64gc -mabi=lp64d -mcmodel=medany -Wall -g -ggdb3 -O0" LDFLAGS="-O3 -ffunction-sections -fdata-sections -fPIC -gdwarf-4 -fno-omit-frame-pointer -march=rv64gc -mabi=lp64d -mcmodel=medany -Wall -g -ggdb3 -O0" "sh" "/mnt/data/devel/ripgrep/target/release/build/jemalloc-sys-eb3f9d51d93e319f/out/build/configure" "--disable-cxx" "--enable-doc=no" "--enable-shared=no" "--with-jemalloc-prefix=_rjem_" "--with-private-namespace=_rjem_" "--host=riscv64gc-unknown-linux-musl" "--build=riscv64gc-unknown-linux-musl" "--prefix=/mnt/data/devel/ripgrep/target/release/build/jemalloc-sys-eb3f9d51d93e319f/out" expected success, got: exit status: 1 ``` Add an entry to build.rs to translate between the GNU target and rustc target in order to work around the mismatch Signed-off-by: Marvin Schmidt <[email protected]>
Signed-off-by: Val Packett <[email protected]>
As otherwise the commit doesn't reliably download on new checkout Signed-off-by: Jack Kleeman <[email protected]>
* Use --with-version when configuring jemalloc This also changes the metadata of the version so that jemalloc still reports the same version as before. Fixes #76 Signed-off-by: Rafael Ávila de Espíndola <[email protected]>
- add m1 macos ci target - feat: add profiling options Signed-off-by: Dan Cline <[email protected]>
) Close #81. Signed-off-by: fys <[email protected]>
jemalloc defaults to enabling stats if `--enable-stats` is not present and `--disable-stats` was not set: https://github.com/jemalloc/jemalloc/blob/fa451de17fff73cc03c31ec8cd817d62927d1ff9/configure.ac#L1331-L1333 the stats feature was always enabled by default and never respected if someone were to remove the stats feature as no logic was added for setting `--disable-stats`. to avoid breaking other user's setups who are relying on this behaviour, set stats as a default feature. Signed-off-by: strawberry <[email protected]>
macos-latest has been switched from x86_64 to aarch64 (https://github.com/actions/runner-images/blob/main/README.md) Signed-off-by: YEUNG King On <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Torrekie <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
BusyJay
force-pushed
the
bump-jemalloc-0.6.0
branch
from
0c9e8d9 to
827ece3
Compare
|
Can this be merged? |
|
Unfortunately no. DCO check failed due to dcoapp/app#114. And I don't have the permission to force merge it yet. /cc @siddontang |
|
I'm afraid it will be difficult to get those commit messages fixed after such a long time. Can @siddontang unblock this? |
|
it'd be nice if we could unblock this so that the 0.6.0 release can be tagged (#98). |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 3, 2024
switch `jemalloc-sys` back to `tikv-jemalloc-sys`, and update to 0.6.0 Some context: - we used to use jemalloc bindings from https://github.com/gnzlbg/jemallocator, since rust-lang#55238 - that crate was abandoned, picked up as a fork in https://github.com/tikv/jemallocator, so we switched to that in rust-lang#83152. - then they were able to publish to the original `jemalloc-sys` bindings crate, and `jemalloc-sys` and `tikv-jemalloc-sys` became the same thing -- so I switched back to the OG crate in rust-lang#96790 - they're now having publishing problems again: I've been waiting for tikv/jemallocator#96 for the `jemalloc-sys` 0.6.0 update for a few months, but `tikv-jemalloc-sys` is already updated to 0.6.0. A perf run showed some improvements, so this PR switches back to `tikv-jemalloc-sys` to update to 0.6.0. r? ghost
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 3, 2024
switch `jemalloc-sys` back to `tikv-jemalloc-sys`, and update to 0.6.0 Some context: - we used to use jemalloc bindings from https://github.com/gnzlbg/jemallocator, since rust-lang#55238 - that crate was abandoned, picked up as a fork in https://github.com/tikv/jemallocator, so we switched to that in rust-lang#83152. - then they were able to publish to the original `jemalloc-sys` bindings crate, and `jemalloc-sys` and `tikv-jemalloc-sys` became the same thing -- so I switched back to the OG crate in rust-lang#96790 - they're now having publishing problems again: I've been waiting for tikv/jemallocator#96 for the `jemalloc-sys` 0.6.0 update for a few months, but `tikv-jemalloc-sys` is already updated to 0.6.0. A perf run showed some improvements, so this PR switches back to `tikv-jemalloc-sys` to update to 0.6.0.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 4, 2024
switch `jemalloc-sys` back to `tikv-jemalloc-sys`, and update to 0.6.0 Some context: - we used to use jemalloc bindings from https://github.com/gnzlbg/jemallocator, since #55238 - that crate was abandoned, picked up as a fork in https://github.com/tikv/jemallocator, so we switched to that in #83152. - then they were able to publish to the original `jemalloc-sys` bindings crate, and `jemalloc-sys` and `tikv-jemalloc-sys` became the same thing -- so I switched back to the OG crate in #96790 - they're now having publishing problems again: I've been waiting for tikv/jemallocator#96 for the `jemalloc-sys` 0.6.0 update for a few months, but `tikv-jemalloc-sys` is already updated to 0.6.0. A perf run showed some improvements, so this PR switches back to `tikv-jemalloc-sys` to update to 0.6.0.
@BusyJay Did it help to use the same email address for your commits and Signed-off-by? What is a force merge, do you mean force push? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.