Skip to content

Add dyke #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add dyke #1929

wants to merge 6 commits into from

Conversation

rwrx
Copy link
Contributor

@rwrx rwrx commented Sep 30, 2019

Add dyke

nvkelso
nvkelso reviewed Sep 30, 2019
View reviewed changes
nvkelso
nvkelso requested changes Sep 30, 2019
View reviewed changes
Copy link
Member

@nvkelso nvkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's an epic misspelling that's been in the project for a while!

@nvkelso
Copy link
Member

nvkelso commented Oct 7, 2019

The CircleCI test failure is because we also need to change dike > dyke in the test:

@rwrx
Copy link
Contributor Author

rwrx commented Oct 9, 2019

Now it seems that tests are ok.

@nvkelso nvkelso added this to the v1.9.0 milestone Nov 11, 2019
@rwrx rwrx mentioned this pull request Mar 21, 2022
Open
@nvkelso nvkelso mentioned this pull request Mar 21, 2022
Open
@nvkelso nvkelso modified the milestones: v1.9.0, v2.0.0 Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvkelso nvkelso nvkelso requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@rwrx @nvkelso