vscode-tilt: fix icon path in package.json #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17 changed the icon value from a path to a url to satisfy the warning "An icon requires a repository with HTTPS protocol to be specified in this package.json.", but then that made publishing fail with "ERROR The specified icon 'extension/https://github.com/raw/tilt-dev/vscode-tilt/main/assets/tilt-transparent.png' wasn't found in the extension."
microsoft/vscode-vsce#341 and microsoft/vscode#30434 make these errors look confusing.
I checked a handful of the top extensions in the vscode marketplace and they all specify their icons as relative paths rather than urls, but they specify their repositories as dicts rather than strings. Changing our repository to a dict and the icon path back to relative made the warning go away 🤷 . I'm guessing the issue is that the vscode warning should have been on the "repository" field for being a string rather than dict.