Skip to content

Conversation

qijun-niu-timeplus
Copy link
Contributor

  • Merge pull request #51710 from velavokr/velavokr-warn-cpu-utilization

A cmake warning on job limits underutilizing CPU

  • Merge pull request #52196 from rschu1ze/simplify-job-limiting

CMake: Simplify job limiting

  • Merge pull request #56971 from ClickHouse/own-cmake-for-grpc

Own CMake for GRPC

  • Merge pull request #70671 from ClickHouse/fix-native-macos

Fix native macOS build


PR checklist:

  • Did you run ClangFormat ?
  • Did you separate headers to a different section in existing community code base ?
  • Did you surround proton: starts/ends for new code in existing community code base ?

Please write user-readable short description of the changes:

* Merge pull request #51710 from velavokr/velavokr-warn-cpu-utilization

A cmake warning on job limits underutilizing CPU

* Merge pull request #52196 from rschu1ze/simplify-job-limiting

CMake: Simplify job limiting

* Merge pull request #56971 from ClickHouse/own-cmake-for-grpc

Own CMake for GRPC

* Merge pull request #70671 from ClickHouse/fix-native-macos

Fix native macOS build

---------

Co-authored-by: Alexey Milovidov <[email protected]>
Co-authored-by: Robert Schulze <[email protected]>
Co-authored-by: Konstantin Bogdanov <[email protected]>
@yokofly
Copy link
Collaborator

yokofly commented Dec 10, 2024

@qijun-niu-timeplus missing one change:

  Build_Native_Darwin_arm64:
    needs: Build_Linux_X86_64
    runs-on: [self-hosted, macOS, ARM64]
    env:
      build_directory: ${{ github.workspace }}/build
--      build_type: Release
++      build_type: RelWithDebInfo

reason: the RelWithDebInfo will add -gdwarf-4 otherwise, it will stuck when throwing exception.
internal discussion: https://timeplus-workspace.slack.com/archives/C076BLFKGHF/p1730872610469759?thread_ts=1730863194.086949&cid=C076BLFKGHF

@qijun-niu-timeplus
Copy link
Contributor Author

@qijun-niu-timeplus missing one change:

  Build_Native_Darwin_arm64:
    needs: Build_Linux_X86_64
    runs-on: [self-hosted, macOS, ARM64]
    env:
      build_directory: ${{ github.workspace }}/build
--      build_type: Release
++      build_type: RelWithDebInfo

reason: the RelWithDebInfo will add -gdwarf-4 otherwise, it will stuck when throwing exception. internal discussion: https://timeplus-workspace.slack.com/archives/C076BLFKGHF/p1730872610469759?thread_ts=1730863194.086949&cid=C076BLFKGHF

resolved, thanks

@yl-lisen yl-lisen merged commit 8b185a3 into develop Dec 17, 2024
21 checks passed
@yl-lisen yl-lisen mentioned this pull request Dec 17, 2024
@jovezhong
Copy link

(Jove Github Bot) added it to the current sprint.

@jovezhong
Copy link

(Jove Github Bot) moved this ticket out of the GitHub project(up to 1200 tickets for one project).

yokofly added a commit that referenced this pull request Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants