feat: Extract generic type for KafkaListeners in batch mode #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timonback
force-pushed
the
feature/payload-schema-for-kafka-batch-listener
branch
2 times, most recently
from
5289884 to
60db5a6
Compare
The KafkaPayloadTypeExtractor contains the logic to extract the payload type, which previously was part of ClassLevelKafkaListenerScanner and MethodLevelKafkaListenerScanner. If the parameter is of type List<?>, reflection is used to extract the underlying type. To demo it, one listener in ExampleConsumer is updated to use batch mode.
Fixes nondeterministic (HashMap) ordering when channels for the same topic are merged
timonback
force-pushed
the
feature/payload-schema-for-kafka-batch-listener
branch
from
f63bbe0 to
cfe5942
Compare
|
merged in upstream |
timonback
deleted the
feature/payload-schema-for-kafka-batch-listener
branch
timonback
pushed a commit
that referenced
this pull request
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The KafkaPayloadTypeExtractor contains the logic to extract the payload type, which previously was part of ClassLevelKafkaListenerScanner and MethodLevelKafkaListenerScanner.
If the parameter is of type List<?>, reflection is used to extract the underlying type.
To demo it, one listener in ExampleConsumer is updated to use batch mode.