Feature/refactoring #22

timrid · 2023-01-03T13:05:43Z

Complete refactoring of the code, so that core components of the construct-editor are seperated vom GUI components. That makes it theoretically possible to add multiple GUI frameworks in the future. Besides this the following notable enhancements are implemented:

Enhanced ConstructEditor:

Any keypress of an printable key will start editing an item. No ENTER or double click is reqired any more.
Protected entries (starting with _) are not visible in list view if "hide protected" is activated. (see also Hidden protected properties visible in list view #13)
Implemented checkbox for cs.Flag
Fixed bug with PaddedString (see also Numeric PaddedString gets parsed as hex number #14)
Added module "construct_editor.core.custom" for easier addition of custom constructs.
Show arrays appropriately (use .[number]. instead of .number.) (see also Improve labels shown by the construct_editor widget #18)
Show full tooltip of the "name" column, which when fields are too long is shown with ellipses. (see also Improve labels shown by the construct_editor widget #18)
Implemented "Copy" / Ctrl+C (see also Improve labels shown by the construct_editor widget #18)
Added "Copy path to clipboard" button in the context menu (see also Improve labels shown by the construct_editor widget #18)
Fixed a bug, when a struct has multiple times the same Enum construct. Then the metadata (eg. byte position) of the last parsed enum value is used for all enum values.
Added exception dialog to show the complete parse/build exception.

Enhanced HexEditor:

fix crash when selecting or extending selection before the beginning of the hex editor using the shift LEFT and UP arrow keys (Fix a number of hex editor issues and add some keyboard management #20)
Add DELETE key to remove a single byte (see also Fix a number of hex editor issues and add some keyboard management #20)
Add INSERT key to add a single byte (see also Fix a number of hex editor issues and add some keyboard management #20)
Add BACK and DELETE key in hex cell editor (see also Fix a number of hex editor issues and add some keyboard management #20)
Add basic arrow keys in hex cell editor doing the same as Escape (see also Fix a number of hex editor issues and add some keyboard management #20)
Optimize paste from clipboard (see also Optimize paste from clipboard #17)

…s are possible (or a text based framework, that can be better unit tested)

… or double click is reqired any more.

… the error of PR #13 (#13).

- added WxObjRendererHelper, so that a Flag can be rendered other than just plain text - Renderer Mode is now dynammically generated by implementing "GetMode"

…stom constructs.

…ubpackage an the `wx` gui package

… PR #20)

#20)

…of the hex editor using the shift LEFT and UP arrow keys (see PR #20)

…(see PR #20)

…g is shown with ellipses. (see #18)

- Added "Copy path to clipboard" button in the context menu (see #18) - Added some methoths for "Paste" but it currently dosnt work correctly.

…ct. Then the metadata (eg. byte position) of the last parsed enum value is used for all enum values.

# Conflicts: # README.md # construct_editor/core/entries.py # construct_editor/widgets/construct_editor.py # construct_editor/wx_widgets/wx_hex_editor.py

timrid added 30 commits December 20, 2022 13:13

start of refactoring most of the code, so that multiple gui framework…

1a18ee4

…s are possible (or a text based framework, that can be better unit tested)

its working again

640ee79

Any keypress of an printable key will start editing an item. No ENTER…

add77b7

… or double click is reqired any more.

added dataclass ValueFromEditorCtrl, to make it more readable

e326830

entry_to_dvc_item and dvc_item_to_entry are now public

1773968

added expand/collapse

4b17501

Added framework independent ContextMenu and an wxPython implementation.

6ae25f7

simplified code for list viewed entries a little bit. This also fixes…

bd896e3

… the error of PR #13 (#13).

removed unnecessary files

e64d247

optimised imports

1affdcb

Implemented undo/redo

a82ed6e

Implemented Checkbox for "cs.Flag":

c7a4836

- added WxObjRendererHelper, so that a Flag can be rendered other than just plain text - Renderer Mode is now dynammically generated by implementing "GetMode"

removed unnecessary code

19b49ba

updated dependencies

1f20656

Show stream infos directly after modifying a value

783c760

completely removed the old CallbackList

6f2d6a9

renamed CallbackListNew to CallbackList

d73f1de

Fixed GetMode in the renderer.

1eaa643

completely removed wx dependency from core components

7c860ad

renamed objects

3a4ef3a

added example screenshot

0f3834f

changed changelog

26d233c

added "WxPythonCodeEditor" for later use

866144a

removed circular imports

7502301

fixed bug with PaddedString (#14)

d87ab53

fixed AttributeError when changing constructs

88cfc64

fixed bug in the restore of the expansion state

3c02ced

fixed flickering on reload

04f213b

added/changed methods for better access

3a884b5

added scripts for automated screenshot generation for the docs

15516dc

timrid added 28 commits December 23, 2022 11:41

fixed setup

16caf3b

fixed "Parameters to generic types must be types." error

65833f5

Added module "construct_editor.core.custom" for easier addition of cu…

1587805

…stom constructs.

fixed ModuleNotFoundError, because of a naming collision bethe wx s…

5053ca3

…ubpackage an the `wx` gui package

incremented construct-typing dependency to 0.5.4

a2a5e7e

fixed custom adapters

f8f13d6

added ExceptionDialog

6bca00d

ignore Intellij, pyCharm, etc. files

ccccc8d

fixed some descriptions

2a8e983

Add basic BACK and DELETE key in hex cell editor (see PR #20)

ac633b0

Add basic arrow keys in hex cell editor doing the same as Escape (see…

3a5981c

… PR #20)

Change "len" variable [which was the same as len()] to "length" (see PR

b39f578

#20)

Catch possible exception on int(value, 16)

c770237

fix crash when selecting or extending selection before the beginning …

ecfc739

…of the hex editor using the shift LEFT and UP arrow keys (see PR #20)

Add Del key to remove a single byte and Ins key to add a single byte …

ab37e41

…(see PR #20)

corrected formating

b0cb915

Appropriately position the cursor after group deletion (see PR #20)

60d5ad1

Added changelog entries

97665d1

Show arrays appropriately (use .[number]. instead of .number.) (see #18)

e93ae21

Show full tooltip of the "name" column, which when fields are too lon…

7ee7858

…g is shown with ellipses. (see #18)

- Implemented "Copy" / Ctrl+C (see #18)

b723d51

- Added "Copy path to clipboard" button in the context menu (see #18) - Added some methoths for "Paste" but it currently dosnt work correctly.

Optimize paste from clipboard (see #17)

e23edfe

Fixed a bug, when a struct has multiple times the same Enum constru…

42ebe71

…ct. Then the metadata (eg. byte position) of the last parsed enum value is used for all enum values.

fixed a few logical changes due to the refactoring

5ae18e0

Added exception dialog to show the complete parse/build exception.

6d0a0cd

fixed changing of objects that are inside an EntryArray

f3a3179

fixed a bug with cs.BytesInteger (eg. cs.Int24ub)

ec5d9a6

Merge branch 'main' into feature/refactoring

f28c306

# Conflicts: # README.md # construct_editor/core/entries.py # construct_editor/widgets/construct_editor.py # construct_editor/wx_widgets/wx_hex_editor.py

timrid merged commit 86bc5fe into main Jan 3, 2023

timrid deleted the feature/refactoring branch January 3, 2023 13:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature/refactoring #22

Feature/refactoring #22

Uh oh!

timrid commented Jan 3, 2023

Uh oh!

Uh oh!

Feature/refactoring #22

Feature/refactoring #22

Uh oh!

Conversation

timrid commented Jan 3, 2023

Uh oh!

Uh oh!