Clear hex selection each time a construct panel entry is selected #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is useful to clear any coloring of performed selection in the hex panel each time an entry is selected in the construct right panel, so that the appropriate set of digits are highlighted in the hex panels, corresponding to the right selection. If this is not done, the highlighted hex digits remain not visible and can be confused with the previous hex selection.
Anyway, I'm not entirely sure that this patch is in the right mode.
Notice also that this patch does not actually cancel the hex selection itself, which can be copied for instance and the related message in the hex panel status line is not removed.