Upgrade to Dart 2.6 #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcharkes
reviewed
Oct 30, 2019
| @@ -58,33 +59,13 @@ class CONSOLE_SCREEN_BUFFER_INFO extends Struct<CONSOLE_SCREEN_BUFFER_INFO> { | |||
| int dwMaximumWindowSizeX; | |||
| @Int16() | |||
| int dwMaximumWindowSizeY; | |||
|
|
|||
| factory CONSOLE_SCREEN_BUFFER_INFO.allocate( | |||
There was a problem hiding this comment.
Did you delete the factory on purpose?
There was a problem hiding this comment.
It didn't look like they were being used, and I was trying to be consistent with the previous changes in https://github.com/timsneath/dart_console/compare/new-ffi-model?expand=1. @timsneath ?
| @@ -28,14 +29,6 @@ class WinSize extends Struct<WinSize> { | |||
|
|
|||
| @Int16() | |||
| int ws_ypixel; | |||
|
|
|||
| factory WinSize.allocate( | |||
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade a few things that were not working in the
new-ffi-modelbranch with2.6.0-dev.8.2cc @dcharkes can you please review?