-
Notifications
You must be signed in to change notification settings - Fork 212
pwm: update drivers with PWM to use new interface #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aykevl
reviewed
Apr 18, 2021
70374d0
to
a679548
Compare
Updated and ready for review @aykevl |
Reminder again that this PR is ready for review. 😸 |
sago35
reviewed
May 2, 2021
Other than the above, I think the rest is good. |
aykevl
reviewed
May 2, 2021
OK, it looks like finally NOW this is done. Ready again for review. |
Signed-off-by: deadprogram <[email protected]>
All feedback has been addressed, so now merging. Thanks @aykevl for the reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that tinygo-org/tinygo#1121 has been merged into TinyGo, this PR is needed to handle the changes to the new PWM API.