Skip to content

main: do not set working directory for Clang invocation #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2019

Conversation

aykevl
Copy link
Member

@aykevl aykevl commented Apr 27, 2019

This commit avoids setting the working directory to the TinyGo root when invocating Clang. This helps to weed out issues before we add support for bundling Clang in a release.

This commit helps #184.

@deadprogram
Copy link
Member

This PR now requires a merge conflict be resolved.

@aykevl aykevl force-pushed the clang-no-working-dir branch from 2f6caa5 to b32a445 Compare May 1, 2019 18:43
@aykevl
Copy link
Member Author

aykevl commented May 1, 2019

Resolved conflict.

This commit avoids setting the working directory to the TinyGo root when
invocating Clang. This helps to weed out issues before we add support
for bundling Clang in a release.
@aykevl aykevl force-pushed the clang-no-working-dir branch from b32a445 to c64dc61 Compare May 2, 2019 13:14
@deadprogram
Copy link
Member

Thanks. Merging.

@deadprogram deadprogram merged commit 1f05954 into dev May 3, 2019
@deadprogram deadprogram deleted the clang-no-working-dir branch May 3, 2019 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants