wasm: implement the //go:wasmimport directive #3165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi, this isn't quite in upstream, yet, though I personally support using this anyway https://go-review.googlesource.com/c/go/+/350737 |
My bad, thanks for correcting. |
|
golang/go@02411bc has landed so hopefully this can move forward :) |
|
Reminder to @aykevl about this one 🛩️ |
It is implemented upstream and looks pretty stable.
|
Updated and removed the commits from #3142 from this PR. |
|
We also need to update Thanks everyone for working on this, exciting to see this moving forward! Now merging. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is
implemented upstreamalmost implemented upstream and looks pretty stable.@neelance I'd like to get your opinion on this.
This would mean that TinyGo implements the
//go:wasmimportdirective for all packages (not just runtime and syscall/js). This seems mostly safe to me, and certainly better than the current//go:wasm-moduledirective that we're using. What do you think, am I missing something?The ABI will be mostly the same as the one used in the Go toolchain, with minor differences here and there. It roughly matches the C ABI.