machine/samd21: Initial implementation of I2S hardware interface #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g Circuit Playground Express Signed-off-by: Ron Evans <[email protected]>
This was referenced May 6, 2019
|
Any feedback on this implementation? |
|
🆗 or ⛔ ? |
|
The PR in general looks good. What I'm mostly worried about is how buffering is done. Does the hardware provide some sort of buffer, or is there a way to transfer using DMA/interrupts? Unlike most other transports (SPI etc.), small delays will disrupt the signal. |
|
Really, this is just a naive interface. A future PR may look into using DMA/buffering. |
aykevl
approved these changes
May 12, 2019
There was a problem hiding this comment.
Ok, perhaps it's better to merge then. I suspect this is going to vary by chip so we could take a look at other chips and update then with an API that takes buffering into account.
I have an I2S DAC lying around somewhere with surprisingly high quality output so I could test that one (also on other line nrf52840?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a very basic initial implementation for the I2S hardware interface tested on the Adafruit Circuit Playground Express. It is only known to work with the PDM microphone that is onboard the Circuit Playground Express, although it might work with other I2S devices.