-
Notifications
You must be signed in to change notification settings - Fork 955
Test for functional argument passing #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for functional argument passing #336
Conversation
I suspect this should fail tests, I think #322 merged into dev, not master. |
Hi @directionless thanks for the PR I changed the branch for it to |
Can you merge these tests in calls.go? By having fewer larger tests, the time to run them is reduced (certainly as long as #285 is not finished). I care a lot about fast tests because the slower the test, the less likely you are to run them. |
Sure. I'm happy to merge this with My bias is also to faster tests, though in my other go projects I haven't found fewer files to be as much of a win. But I also use a lot of parallelization. I tossed a bunch of stuff into #337 around that. On my machine, it seems to cut the test time in half. I'm curious what you think of that approach. |
Tests for tinygo-org#322 (And a .gitignore addition for llvm)
3e6fafb
to
9b2d351
Compare
0de22ac
to
f00fe8b
Compare
Thanks for the additional tests @directionless now merging. |
Technically varargs are a matter for the frontend (https://godoc.org/golang.org/x/tools/go/ssa) because on the Go SSA level, all varargs are replaced with slices already so doesn't really need to care about this, but it's good to test it anyway to be sure. |
* Test for functional argument passing
Tests for #322
(And a .gitignore addition for llvm)