Skip to content

runtime/all: add implementation of bytealg.CountString to complete #424 #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

deadprogram
Copy link
Member

This PR adds an implementation of bytealg.CountString to complete #424 based on the information located by @1l0

@niaow
Copy link
Member

niaow commented Oct 7, 2019

This looks good to me, but is bytealg.Count actually implemented? If not, would it make sense to add it here too?

@deadprogram
Copy link
Member Author

I did not run into a specific need for it myself, whereas I did run into an error due to missing bytealg.CountString when using the mqttclient under go 1.13. That is the only reason.

Copy link
Member

@niaow niaow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@aykevl aykevl merged commit b730590 into dev Oct 9, 2019
@aykevl aykevl deleted the feature/add-countstring branch October 9, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants