Give readable names to subtests and run in parallel #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh. Something appears to have gone wrong sometimes. |
|
Looking at the errors this indicates some sort of memory corruption. See also #337. I had hoped that this would have been fixed with the correctness fixes you did but it doesn't look like it unfortunately. |
|
It looks like we are using the global context for the one thing my IR checker did not check |
niaow
force-pushed
the
testnames
branch
6 times, most recently
from
eb6593b to
048cdfe
Compare
|
Alright, I am out of ideas. |
niaow
force-pushed
the
testnames
branch
3 times, most recently
from
b824828 to
6631fc7
Compare
|
Perhaps you could split this into two PRs? The first one just for the subtests (which is a relatively simple change) and then we can look at parallelizing LLVM. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch restructures the tests a bit so that the names of the subtests indicate the platform that they were run on. Additionally, the tests are now run in parallel. On my machine, this reduced the time needed to run the tests from 81 seconds to 28 seconds.