Export implementations of malloc/free for use from C #997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have done some size tests to make sure this doesn't blow up size unexpectedly, and it only seems to increase code size on very small blinking LED samples. Any real programs will have no or very moderate (16 bytes) increases in binary size, so I think it's fine. Because this code is only relevant on baremetal targets, I think it makes sense to move it to src/runtime/baremetal.go, which is already protected by the same build constraint. |
aykevl
reviewed
Mar 29, 2020
|
Thank you! Squashed/merged your changed in the dev branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are implementations of malloc and free that delegate to the GC implementation.
Note: I'm not totally sure what the correct build tag to use for this is, if any.
baremetalseems to work well but please feel free to suggest an alternative if there is something more appropriate. Also if you think that there is so better design for how these should be implemented that is fine too.