Skip to content

Сompatibility with msgppack-php #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Сompatibility with msgppack-php #137

wants to merge 1 commit into from

Conversation

darvik80
Copy link

  1. Changes in read*.go compatibility with https://github.com/msgpack/msgpack-php
  2. Changes in gen/elem.go && gen/spec.go fix it:
//go:generate msgp
package main

type SomeStruct map[string]string

type SomeMegaStruct struct {
    Struct1 *SomeStruct `msg:"struct-1"`
    Struct2 *SomeStruct `msg:"struct-2"`
}

Review on Reviewable

@philhofer
Copy link
Member

The best way to read numbers that come from languages that do not draw distinctions between the signed and unsigned integers (or floating-point numbers, for that matter) is to use msgp.Number, which will happily decode signed and unsigned integers and single- and double-precision floats.

@client9
Copy link
Contributor

client9 commented Nov 20, 2015

see also #134

@shabbyrobe
Copy link
Contributor

I think this is covered by #215 too?

@philhofer philhofer closed this Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants