Skip to content

implements cast methods for (u)int64 and (u)int32 #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

implements cast methods for (u)int64 and (u)int32 #153

wants to merge 1 commit into from

Conversation

dwlnetnl
Copy link

See discussion #134.


This change is Reviewable

@philhofer
Copy link
Member

You've added some additional same-type casts here, but I think #134 was more about cross-type casts that succeed because the 'value' of the number is the same (e.g., the bits 0x0000000000000000 and 0x8000000000000000 are both the value 0 under IEEE-754, so casting those to any integral type would be legal. Similarly, integral numbers that fit in a floating-point mantissa could be legally casted to floats as well.)

@dwlnetnl dwlnetnl closed this Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants