Replace uninitialized @separator with @word_separator in NGram#parse #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
le-blau
force-pushed
the
replace-separator
branch
from
6060cfa to
7227132
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Overview
In the
parsemethod of theNGramclass,@separatorwas being used without being properly defined or initialized. However, due to Ruby's behavior,split(nil)defaulted to splitting by whitespace, so no error was occurring.The code will not behave as expected when trying to specify a custom separator.
Fix Details
@separatorhas been replaced with@word_separatorto ensure that an intentionally set separator is used.