-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
screenkey: add page #5999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
screenkey: add page #5999
Conversation
Hi @ashishbinu thanks for your first PR, this process till merging may take hours or it may take take days depending on how many errors there maybe, please stay with each suggestion and give your opinions/commit them |
@CleanMachine1 I made my suggestions an hour ago but forgot to submit them — do you mind if I hide yours that conflict with mine? |
If yours are better sure |
Co-authored-by: CleanMachine1 <[email protected]> Co-authored-by: bl-ue <[email protected]>
Unaware why the workflow didn't run after commits, it was approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We tend not to use you and your
Co-authored-by: CleanMachine1 <[email protected]>
Co-authored-by: bl-ue <[email protected]>
Co-authored-by: marchersimon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @ashishbinu
common/
,linux/
, etc.)