Skip to content

Conversation

ashishbinu
Copy link
Contributor

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@bl-ue bl-ue added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label May 19, 2021
@CleanMachine1
Copy link
Member

Hi @ashishbinu thanks for your first PR, this process till merging may take hours or it may take take days depending on how many errors there maybe, please stay with each suggestion and give your opinions/commit them

@bl-ue
Copy link
Contributor

bl-ue commented May 19, 2021

@CleanMachine1 I made my suggestions an hour ago but forgot to submit them — do you mind if I hide yours that conflict with mine?

@CleanMachine1
Copy link
Member

If yours are better sure

@CleanMachine1
Copy link
Member

Unaware why the workflow didn't run after commits, it was approved

Copy link
Member

@CleanMachine1 CleanMachine1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tend not to use you and your

Copy link
Contributor

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @ashishbinu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants