Add Lines, Chars and CharsMut iterators #31
Conversation
- Add a test that <Lines as ExactSizeIterator>::len is correct
| /// An iterator over the lines of the internal character array. | ||
| #[derive(Debug)] | ||
| pub struct Lines<'a> { | ||
| // TODO: should this use `core::slice::Split` internally? |
There was a problem hiding this comment.
core::slice::Split only allows a single byte at a time to be checked. We would check for \n and then see if there was a \r right before I guess. In this case I think using the memchr crate would give a nice speedup.
Do you like to try implementing this? If not, no problem, I'll just open an issue to not forget it.
src/ascii_str.rs
Outdated
| Some(i) => i, | ||
| None => return None | ||
| }; | ||
| let line: &AsciiStr = From::from(&self.string[curr_idx..next_idx]); |
There was a problem hiding this comment.
self.string is already of type &AsciiStr which makes the From::from conversion redundant. You can simply omit it.
|
|
||
| #[inline] | ||
| fn size_hint(&self) -> (usize, Option<usize>) { | ||
| (self.len(), Some(self.len())) |
There was a problem hiding this comment.
I guess the compiler is smart enough to optimize this such that the entire string is only once iterated over instead of twice. I will check this, but it's only a minor observation.
src/ascii_str.rs
Outdated
| if i == 0 { | ||
| *achar = AsciiChar::H; | ||
| } | ||
| } |
There was a problem hiding this comment.
if i == 0 makes the for-loop redundant. Maybe rewrite this as:
*ascii.chars_mut().next().unwrap() = AsciiChar::H;
|
Thanks for your replies. Unfortunately, I've realised that the |
|
I think I'll close this pr, and open a new one with the more focused changes (aka Chars, CharsMut and lines without the len stuff). Then those can be added as future improvements. |
Adds iterators over lines, chars and a mutable iterator over characters, and adds tests as well.