More valid schema value types. #204
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonsky
force-pushed
the
master
branch
3 times, most recently
from
ada9497 to
130e06f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds more schema value types, even though Datascript doesn't care about the type other than if it's a
:db.type/refor not. The value type keywords follow closely with Datomic.This allows using a schema defined for Datascript to drive schemas for other databases that care more about type such as Datomic or ElasticSearch.
If it is preferred that
:db.type/refis the only valid type, we could instead have that refer to adef'ed value containing a set of:db.type/ref. This would allow monkey-patching by other modules by redefining the value.This change is