-
Notifications
You must be signed in to change notification settings - Fork 46
Add auto-complete to the P5 widget #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
"chai": "^3.5.0", | ||
"webpack-dev-server": "^1.14.1" | ||
"mocha-chrome": "^2.2.0", | ||
"mocha-phantomjs": "^4.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove obsolete phantomjs
@@ -47,6 +62,14 @@ module.exports = configurations({ | |||
'preview-frame': './lib/preview-frame.ts', | |||
'tests': './test/main.tsx' | |||
}, | |||
devServer: { | |||
// historyApiFallback: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this!
Hi @citelao , I would like to know this details from p5.js-widget tool in this repo there is no discussions tab so i am asking in this feature auto-complete pull request. |
@Mamatha1718 I am not the right person to ask; you should open an issue if you're confused about the documentation. |
@citelao ,Thank for your clarification |
This (super preliminary) draft change adds IntelliSense/autocomplete to the editor!
To best handle this change, I switched the editor from CodeMirror to Monaco (the base of VS Code), since Monaco handles autocomplete much better (and by default!). This required a lot of other changes---updating the Webpack versions significantly, etc.
There's a ton of work left---
the editor is mis-sized(fixed!)and does not support undo/redo yet(supports undo now!). See the TODOs!But wow, it's so cool!
Example
You can mess with it at https://ben.stolovitz.com/p5.js-widget/!
Previous screenshots
Before style changes:

Notes
@types/p5
since that is used for the auto-complete (yeah, ew).index.html
etc tostatic/
.TODO